Skip to content

feat: Avoid starting useless DKG threads on regular non-watching nodes#4946

Merged
UdjinM6 merged 2 commits into
dashpay:developfrom
UdjinM6:no_useless_dkg
Aug 6, 2022
Merged

feat: Avoid starting useless DKG threads on regular non-watching nodes#4946
UdjinM6 merged 2 commits into
dashpay:developfrom
UdjinM6:no_useless_dkg

Conversation

@UdjinM6
Copy link
Copy Markdown

@UdjinM6 UdjinM6 commented Jul 30, 2022 •
edited
Loading

36 threads less on regular non-watching nodes.

Have to refactor AppInitMain slightly to be able to access fMasternodeMode in CDKGSessionManager ctor.

@UdjinM6 UdjinM6 marked this pull request as ready for review July 30, 2022 20:42
@UdjinM6 UdjinM6 requested a review from PastaPastaPasta August 5, 2022 08:34
PastaPastaPasta
PastaPastaPasta approved these changes Aug 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@UdjinM6 UdjinM6 added this to the 18.1 milestone Aug 6, 2022
@UdjinM6 UdjinM6 merged commit 8882a73 into dashpay:develop Aug 6, 2022
@UdjinM6 UdjinM6 deleted the no_useless_dkg branch August 6, 2022 08:50
@kwvg
Copy link
Copy Markdown
Collaborator

kwvg commented Aug 8, 2022 •
edited
Loading 

llmq/dkgsessionmgr.cpp: In constructor 'llmq::CDKGSessionManager::CDKGSessionManager(CConnman&, CBLSWorker&, CSporkManager&, bool, bool)':
llmq/dkgsessionmgr.cpp:31:30: error: 'CLLMQUtils' has not been declared
   31 |     if (!fMasternodeMode && !CLLMQUtils::IsWatchQuorumsEnabled()) {
      |                              ^~~~~~~~~~

See https://gitlab.com/dashpay/dash/-/jobs/2825097900 Fix already staged here... #4957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.1

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6 @kwvg @PastaPastaPasta