fix(tests): params cleanup in pow_tests/get_next_work#5067
Merged
Conversation
PastaPastaPasta
approved these changes
Nov 2, 2022
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
PastaPastaPasta
changed the title
pow_tests/get_next_workpow_tests/get_next_work
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jul 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Avoid leaking
devnetparam into other tests.https://gitlab.com/UdjinM6/dash/-/jobs/3221459032#L3035: note lots of
Error: -port must be specified when -devnet and -listen are specifiedWhat was done?
How Has This Been Tested?
0aa5dc0251 https://gitlab.com/UdjinM6/dash/-/jobs/3247713299
Breaking Changes
none
Checklist:
For repository code-owners and collaborators only