Skip to content

ci: more checksums in guix workflow#5417

Merged
PastaPastaPasta merged 2 commits into
dashpay:developfrom
UdjinM6:ci_guix_workflow_more_checksums
Jun 9, 2023
Merged

ci: more checksums in guix workflow#5417
PastaPastaPasta merged 2 commits into
dashpay:developfrom
UdjinM6:ci_guix_workflow_more_checksums

Conversation

@UdjinM6
Copy link
Copy Markdown

@UdjinM6 UdjinM6 commented Jun 7, 2023

Issue being fixed or feature implemented

  1. not all binaries were covered with checksums
  2. there were no checksums for archives

What was done?

add missing checksums, also group and sort them

How Has This Been Tested?

run commands after local guix build
see this PR results

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

also group and sort them
@UdjinM6 UdjinM6 added this to the 20 milestone Jun 7, 2023
PastaPastaPasta
PastaPastaPasta previously approved these changes Jun 8, 2023
Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

Comment thread .github/workflows/guix-build.yml Outdated
@UdjinM6 UdjinM6 marked this pull request as ready for review June 8, 2023 19:04
Copy link
Copy Markdown
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure unrelated to changes made, utACK

Copy link
Copy Markdown
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit c51ba63 into dashpay:develop Jun 9, 2023
@UdjinM6 UdjinM6 deleted the ci_guix_workflow_more_checksums branch June 10, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants