Skip to content

docs: update man pages#5672

Merged
PastaPastaPasta merged 2 commits into
dashpay:developfrom
UdjinM6:genmanpages
Nov 7, 2023
Merged

docs: update man pages#5672
PastaPastaPasta merged 2 commits into
dashpay:developfrom
UdjinM6:genmanpages

Conversation

@UdjinM6
Copy link
Copy Markdown

@UdjinM6 UdjinM6 commented Nov 5, 2023

Issue being fixed or feature implemented

What was done?

./contrib/devtools/gen-manpages.sh and drop rc2 and dirty suffixes

How Has This Been Tested?

n/a

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 20 milestone Nov 5, 2023
knst
knst previously approved these changes Nov 6, 2023
Copy link
Copy Markdown
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK (but check a comment for font weight

2 things are different with my run:

  • default font weight (see a comment for details)
  • amount of cores for verification threads (param name is -par): it can't be fixed easily and the same issue for bitcoin.

Comment thread doc/man/dash-qt.1 Outdated
Copy link
Copy Markdown
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Copy Markdown

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PastaPastaPasta PastaPastaPasta merged commit ab56dcf into dashpay:develop Nov 7, 2023
@knst knst mentioned this pull request Nov 13, 2023
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants