docs: update release process document to follow-up v20 release#5710
Merged
Conversation
64cf5e6 to
ed9d86e
Compare
Collaborator
Author
|
Link to preview how this MD file is rendered by GitHub: https://github.com/dashpay/dash/blob/ed9d86e9805e93a05fe6b81a2acb764e34b9ffb5/doc/release-process.md |
| - Testnet should be set some tens of thousands back from the tip due to reorgs there. | ||
| - This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect | ||
| that causes rejection of blocks in the past history. | ||
| * [ ] Ensure that governance is functional after sentinel changes are done |
Member
There was a problem hiding this comment.
this is not needed moving forward
Suggested change
| * [ ] Ensure that governance is functional after sentinel changes are done |
Comment on lines
+113
to
+117
| * [ ] Pasta Guix Build | ||
| * [ ] UdjinM6 Guix Build | ||
| * [ ] Thephez Guix Build | ||
| * [ ] kwvg Guix Build | ||
| * [ ] knst Guix Build |
Member
There was a problem hiding this comment.
I'd prefer not enumerating these here as this can change from version to version
Comment on lines
+171
to
+175
| * [ ] Pasta | ||
| * [ ] UdjinM6 | ||
| * [ ] Thephez | ||
| * [ ] kwvg | ||
| * [ ] knst |
thephez
requested changes
Nov 20, 2023
Collaborator
thephez
left a comment
There was a problem hiding this comment.
Some suggested updates and corrections...
thephez
approved these changes
Nov 20, 2023
Collaborator
thephez
left a comment
There was a problem hiding this comment.
Looks good. Thanks for updating this 👍
UdjinM6
requested changes
Nov 21, 2023
UdjinM6
left a comment
There was a problem hiding this comment.
pls see UdjinM6@1038c1a for some suggestions
Co-authored-by: thephez <thephez@users.noreply.github.com>
f1e92c3 to
d029fdb
Compare
PastaPastaPasta
approved these changes
Nov 26, 2023
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Our Release Process document is not exactly matched with our template issue that created by copy-paste from previous release.
For the next release just copy test from this document to new issue
What was done?
Release Process document is updated to match with our real release process.
This document has also detailed instructions for many steps (in compare to the issue that we use now which is more checklist) to make releasing process easier for all participant.
How Has This Been Tested?
Tested on air by 2 last released: v19, v20: #5694
Breaking Changes
N/A
Checklist: