fix: CheckQuorumConnections should not be running on regular non-watching nodes

[UdjinM6]

Issue being fixed or feature implemented

No need to waste CPU on regular non-watching nodes

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[knst]

should not it be CQuorumManager::UpdatedBlockTip instead?

 void CQuorumManager::UpdatedBlockTip(const CBlockIndex* pindexNew, bool fInitialDownload) const
+    if (!fMasternodeMode && !utils::IsWatchQuorumsEnabled()) return;
     if (!m_mn_sync->IsBlockchainSynced()) {
         return;
     }

mapQuorumData seems used only for MNs; CleanupOldQuorumData and TriggerQuorumDataRecoveryThreads both check flags fMasternodeMode too.

[UdjinM6]

Good catch! 👍 There are indeed more related things to fix. I opened #5745 to address them all.

[UdjinM6]

superseded by #5745