refactor: drop usages of llmq/utils to check if hard-fork is active#5753

Merged

PastaPastaPasta merged 34 commits into

dashpay:developfrom

knst:refactor-llmq_vbc

Dec 22, 2023

Commits on Dec 22, 2023

chore: add TODO for llmq/utils.h refactoring

knst
authored and
PastaPastaPasta
committed
refactor: drop IsDIP0024Active and its usage of llmq_vbc

knst
authored and
PastaPastaPasta
committed
refactor: use value_or in std::optional

knst
authored and
PastaPastaPasta
committed
refactor: drop dependency governance/classes on llmq/utils

knst
authored and
PastaPastaPasta
committed
refactor: drop dependency masternode/payments on llmq/utils

knst
authored and
PastaPastaPasta
committed
refactor: drop dependency unit test block_reward_reallocation_tests on llmq/utils

knst
authored and
PastaPastaPasta
committed
fix: use proper pindex/pindex->pprev in credit pool code during v20/mn_rr activations

knst
authored and
PastaPastaPasta
committed
refactor: drop dependency of specialtxman on llmq/utils

knst
authored and
PastaPastaPasta
committed
refactor: drop dependency creditpool on llmq/utils

knst
authored and
PastaPastaPasta
committed
refactor: rename argument pindex to pindexPrev in GetMNPayee and GetProjectedMNPayees

knst
authored and
PastaPastaPasta
committed
refactor: move common code in deterministicmns to the helper

knst
authored and
PastaPastaPasta
committed
refactor: use deployment status in deterministicmns instead llmq's helpers

knst
authored and
PastaPastaPasta
committed
refactor: drop default value from IsDIP3Enforced()

knst
authored and
PastaPastaPasta
committed
refactor: move out helper IsDIP3Enforced from deterministicmns

knst
authored and
PastaPastaPasta
committed
refactor: drop unused llmq::utils::IsMNRewardReallocationActive

knst
authored and
PastaPastaPasta
committed
refactor: drop dependency evo/simplifiedmns on llmq/utils

knst
authored and
PastaPastaPasta
committed
refactor: use DeploymentActiveAfter in ehf_signals

knst
authored and
PastaPastaPasta
committed
refactor: use DeploymentActiveAfter in cbtx

knst
authored and
PastaPastaPasta
committed
refactor: use DeploymentActiveAfter in evo/mnauth

knst
authored and
PastaPastaPasta
committed
refactor: use CFinalCommitment::GetVersion in llmq/{commitment,dkgsession}

knst
authored and
PastaPastaPasta
committed
refactor: use DeploymentActiveAfter in init.cpp

knst
authored and
PastaPastaPasta
committed
refactor: drop dependency test/util/setup_common on llmq/utils

knst
authored and
PastaPastaPasta
committed
refactor: use DeploymentActiveAfter instead llmq::utils in rpc/

knst
authored and
PastaPastaPasta
committed
refactor: use DeploymentActiveAfter in llmq/blockprocessor

knst
authored and
PastaPastaPasta
committed
refactor: drop dependency test/evo_deterministicmns_tests on llmq::utils

knst
authored and
PastaPastaPasta
committed
refactor: drop public method llmq::utils::IsV19Active

knst
authored and
PastaPastaPasta
committed
refactor: drop dependency miner on llmq::utils::IsV20Active

knst
authored and
PastaPastaPasta
committed
refactor: drop dependency validation on llmq/utils

knst
authored and
PastaPastaPasta
committed
chore: removed TODO for TESTNET_LLMQ_25_67_ACTIVATION_HEIGHT so far as have no idea why it is not matching with v19 activation

knst
authored and
PastaPastaPasta
committed
refactor: drop public llmq::utils::IsV20Active method

knst
authored and
PastaPastaPasta
committed
refactor: drop llmq_versionbitscache in favor of g_versionbitscache

knst
authored and
PastaPastaPasta
committed
fix: remove unused cs_main lock from src/miner.cpp - it's not used by EHF logic anymore

knst
authored and
PastaPastaPasta
committed
refactor: drop global variable fDIP0001ActiveAtTip - partial implementation

knst
authored and
PastaPastaPasta
committed
chore: remaining TODO goes to other PRs

knst
authored and
PastaPastaPasta
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: drop usages of llmq/utils to check if hard-fork is active#5753

refactor: drop usages of llmq/utils to check if hard-fork is active#5753
PastaPastaPasta merged 34 commits into
dashpay:developfrom
knst:refactor-llmq_vbc

Commits on Dec 22, 2023

chore: add TODO for llmq/utils.h refactoring

refactor: drop IsDIP0024Active and its usage of llmq_vbc

refactor: use value_or in std::optional

refactor: drop dependency governance/classes on llmq/utils

refactor: drop dependency masternode/payments on llmq/utils

refactor: drop dependency unit test block_reward_reallocation_tests on llmq/utils

fix: use proper pindex/pindex->pprev in credit pool code during v20/mn_rr activations

refactor: drop dependency of specialtxman on llmq/utils

refactor: drop dependency creditpool on llmq/utils

refactor: rename argument pindex to pindexPrev in GetMNPayee and GetProjectedMNPayees

refactor: move common code in deterministicmns to the helper

refactor: use deployment status in deterministicmns instead llmq's helpers

refactor: drop default value from IsDIP3Enforced()

refactor: move out helper IsDIP3Enforced from deterministicmns

refactor: drop unused llmq::utils::IsMNRewardReallocationActive

refactor: drop dependency evo/simplifiedmns on llmq/utils

refactor: use DeploymentActiveAfter in ehf_signals

refactor: use DeploymentActiveAfter in cbtx

refactor: use DeploymentActiveAfter in evo/mnauth

refactor: use CFinalCommitment::GetVersion in llmq/{commitment,dkgsession}

refactor: use DeploymentActiveAfter in init.cpp

refactor: drop dependency test/util/setup_common on llmq/utils

refactor: use DeploymentActiveAfter instead llmq::utils in rpc/

refactor: use DeploymentActiveAfter in llmq/blockprocessor

refactor: drop dependency test/evo_deterministicmns_tests on llmq::utils

refactor: drop public method llmq::utils::IsV19Active

refactor: drop dependency miner on llmq::utils::IsV20Active

refactor: drop dependency validation on llmq/utils

chore: removed TODO for TESTNET_LLMQ_25_67_ACTIVATION_HEIGHT so far as have no idea why it is not matching with v19 activation

refactor: drop public llmq::utils::IsV20Active method

refactor: drop llmq_versionbitscache in favor of g_versionbitscache

fix: remove unused cs_main lock from src/miner.cpp - it's not used by EHF logic anymore

refactor: drop global variable fDIP0001ActiveAtTip - partial implementation

chore: remaining TODO goes to other PRs