backport: merge bitcoin#16337, #16378, #20179, #19969 (send rpc)#5861
Merged
Conversation
|
This pull request has conflicts, please rebase. |
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
previously approved these changes
Mar 6, 2024
UdjinM6
reviewed
Mar 6, 2024
knst
previously approved these changes
Mar 6, 2024
Collaborator
knst
left a comment
knst
left a comment
There was a problem hiding this comment.
LGTM but check rpc dashification s/satoshi/duffs
|
This pull request has conflicts, please rebase. |
knst
reviewed
Mar 7, 2024
Collaborator
knst
left a comment
knst
left a comment
There was a problem hiding this comment.
- I just found one releavant backport:
e36aa35 Merge bitcoin#19969: Send RPC bug fix and touch-ups
Consider including it to this PR
- I just discovered that we have CURRENCY_ATOM defined since bitcoin#11413 and bitcoin uses it in the later commits for rpc wallet.
+const std::string CURRENCY_ATOM = "duff"; // One indivisible minimum value unit
considerusing CURRENCY_ATOM instead duffs directly
…efundedpsbt Co-authored-by: Konstantin Akimov <knstqq@gmail.com>
kwvg
changed the title
UdjinM6
approved these changes
Mar 7, 2024
knst
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Information
Extracted from dash#5842 due to breaking changes and placed into its own PR to be merged during new major version development cycle.
Breaking Changes
(Taken from
release-notes-5861.md)The
walletcreatefundedpsbtRPC call will now fail withInsufficient fundswhen inputs are manually selected but are not enough to cover the outputs and fee. Additional inputs can automatically be added through the newadd_inputsoption.The
fundrawtransactionRPC now supportsadd_inputsoption that whenfalseprevents adding more inputs if necessary and consequently the RPC fails.A new
sendRPC with similar syntax towalletcreatefundedpsbt, including support for coin selection and a custom fee rate. ThesendRPC is experimental and may change in subsequent releases. Using it is encouraged once it's no longer experimental:sendmanyandsendtoaddressmay be deprecated in a future release.Checklist