backport: merge bitcoin#22029, #27538, #21100, #27542, #24005, partial bitcoin#19953, #23394, #20292, #20161, #20842, #26222 (secp256k1 tests)#5873
Merged
Conversation
PastaPastaPasta
approved these changes
Feb 19, 2024
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
includes: - ca83ffc (only changes to test/ functional/test_framework/key.py)
includes: - 50eb0c2 (only changes to test/ functional/test_framework/key.py)
includes: - 1d22300
These changes were introduced in bitcoin#15514 (Update Transifex links), which ordinarily do not apply to Dash as it uses its own Transifex account but not mentioned in the name are updates to Doxygen URLs.
The changes are a portion of bitcoin#17873, the rest of which is merged into `developer-notes.md`, leaving this change out for some reason.
…p classes to test framework notes: - excludes changes to test/functional/feature_taproot.py
PastaPastaPasta
force-pushed
the
secp_tests
branch
from
cfc2c4e to
3710439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Information
As mentioned in a comment on dash#5575, partials will remain present as a lot of the associated changes needed for BIP324 coincide with work on Taproot.
This does come with the problematic side effect of complicating Taproot backporting efforts should it be undertaken in the future as the codebase would contain bits and pieces of code that assume changes in Taproot logic, for example, using APIs that have already been changed, requiring OOO modifications to be usable.
bitcoin#23394 is listed as unmerged despite the changes making it to the codebase vide merge commit bitcoin@5ccab71, see comment.
bitcoin#27542 is a followup to bitcoin#23716 (which was backported via dash#4843)
Breaking Changes
None, changes are limited to Python-based tests, one fuzzing test and code comments.
Checklist: