test: reduce BRRHeight in regtest#6176
Merged
PastaPastaPasta merged 1 commit intoAug 7, 2024
Merged
Conversation
knst
previously approved these changes
Aug 5, 2024
Member
|
doing: |
UdjinM6
previously requested changes
Aug 6, 2024
knst
reviewed
Aug 6, 2024
Collaborator
There was a problem hiding this comment.
Suggested change
| consensus.BRRHeight = 1000; // see block_reward_reallocation_tests | |
| consensus.BRRHeight = 900; // see block_reward_reallocation_tests |
Values lower than 900 I would not set because it would be less than DIP0024 and V19. But I see no issues with (not tested by me)
ogabrielides
changed the title
knst
approved these changes
Aug 7, 2024
Collaborator
knst
left a comment
knst
left a comment
There was a problem hiding this comment.
utACK dd64749167c7524ac13493bab46a58281e7bd9b7
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 7, 2024
38ecd6f test: reduce BRRHeight on regtest (Odysseas Gabrielides) Pull request description: ## Issue being fixed or feature implemented In regtest, Block Reward Reallocation is buried at height 2500, which happens after v20 activation. ## What was done? Reduced BRRHeight in regtest from 2500 to 1000. The purpose of this change is to simplify regtests of Platform as well. Note: This change affects only regtest. ## How Has This Been Tested? tests ## Breaking Changes no, this only affects Regtest (where we make no guarantees about breaking stuff) ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Top commit has no ACKs. Tree-SHA512: b5a1c2b2c2b70682f266d9d0af9e048a03417c0cb2480eb5ab5838965342b6465acd10d8dac5a0d3c5c5f59f4e36ac5b909a838bc3805c2265a83776e92b4827
PastaPastaPasta
added a commit
that referenced
this pull request
Aug 7, 2024
8e9dd12 chore: bump version in configure.ac (pasta) afb8dc0 docs: add v21.1.0 release notes and archive v21.0.2 (pasta) 269dd02 Merge #6179: chore: update manpages v21.1 (pasta) a8cb643 Merge #6175: feat: allow resigning for EHF (pasta) de5cc22 Merge #6178: chore: bump protocol version to 70233 (pasta) 2de4ce5 Merge #6176: test: reduce BRRHeight in regtest (pasta) 840175e Merge #6174: fix: stop trying to sign pending txes when they are no longer non-locked (pasta) Pull request description: ## Issue being fixed or feature implemented Backports for v21.1.0, add release notes and ## What was done? See commits ## How Has This Been Tested? Been on devnet ## Breaking Changes None ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: knst: utACK 8e9dd12 Tree-SHA512: 3c968c4f0e06bc88f63bf10f742d39595c45c7fcd4aef1891d2e76d9f443cae1ddd3cb84c787faa189ef3a189a9dd63a7f75e69f5787a47d1281d5b6a445a2a6
PastaPastaPasta
added a commit
that referenced
this pull request
Aug 9, 2024
8e9dd12 chore: bump version in configure.ac (pasta) afb8dc0 docs: add v21.1.0 release notes and archive v21.0.2 (pasta) 269dd02 Merge #6179: chore: update manpages v21.1 (pasta) a8cb643 Merge #6175: feat: allow resigning for EHF (pasta) de5cc22 Merge #6178: chore: bump protocol version to 70233 (pasta) 2de4ce5 Merge #6176: test: reduce BRRHeight in regtest (pasta) 840175e Merge #6174: fix: stop trying to sign pending txes when they are no longer non-locked (pasta) Pull request description: ## Issue being fixed or feature implemented ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK 058ff45 kwvg: utACK 058ff45 Tree-SHA512: b619f9754258cece012f817a523f5849128e044ffbe17a28e12f1e8424d11f6a4c8d011a554fce0b106e1d6efee2aa306befdc034b8e47be077ad28c7f39c975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
In regtest, Block Reward Reallocation is buried at height 2500, which happens after v20 activation.
What was done?
Reduced BRRHeight in regtest from 2500 to 1000.
The purpose of this change is to simplify regtests of Platform as well.
Note: This change affects only regtest.
How Has This Been Tested?
tests
Breaking Changes
no, this only affects Regtest (where we make no guarantees about breaking stuff)
Checklist: