fix(qt): set prune dependent options correctly#6368
Merged
Conversation
A few things to note: 1. we shouldn't rely on `bPrune` cause it can be overridden via cmd-line 2. `addOverriddenOption` is used to highlight that there are GUI options that were overridden via cmd-line and neither `-disablegovernance` nor `-txindex` override anything, we simply set them to correct values here. 3. we should do all that in `SetPruneEnabled` case that's the central point for GUI prune option logic
kwvg
reviewed
Oct 28, 2024
5 tasks
…uning is requested via init dialog
kwvg
approved these changes
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
A few things to note:
bPrunecause it can be overridden via cmd-lineaddOverriddenOptionis used to highlight that there are GUI options that were overridden via cmd-line and neither-disablegovernancenor-txindexoverride anything, we simply set them to correct values here.SetPruneEnabledcase that's the central point for GUI prune option logicfixes #6366
#6367 alternative
What was done?
How Has This Been Tested?
./src/qt/dash-qt --regtest --resetguisettings(could also add--txindex=1and/or--disablegovernance=0), check "Limit ..." box, click OK and confirm it continues with no errors (but with a warning about disabled governance, that's by design)close qt and check 2 more things:
./src/qt/dash-qt --regtestshould have a warning about disabled governance./src/qt/dash-qt --regtest --prune=0should have no warning about disabled governance (not true ondevelop)Breaking Changes
Checklist: