fix: don't shrink window when setting minimum width#6471
Merged
Conversation
PastaPastaPasta
approved these changes
Dec 9, 2024
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
generally utACK e080686
Can you describe how you tested this?
Collaborator
Author
|
Updated PR description to include testing method |
knst
approved these changes
Dec 10, 2024
UdjinM6
approved these changes
Dec 10, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Information
How Has This Been Tested?
Crossed compiled for
x86_64-w64-mingw32and tested resultingdash-qt.exeon Windows 11 22H2 (Build 22621.431). Followed reproduction steps as mentioned in dash#5886, found width to persist even after closing Options modal using buttons and the close button on the top right.Breaking Changes
None expected.
Checklist: