test: actually use masternode with basic bls pubkey in mnauth test#6481
Merged
Conversation
PastaPastaPasta
previously approved these changes
Dec 11, 2024
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
makes sense, and change looks right.
utACK 3db20e3
knst
reviewed
Dec 12, 2024
|
|
||
| def run_test(self): | ||
| self.activate_v19(expected_activation_height=900) | ||
| self.dynamically_add_masternode() |
Collaborator
There was a problem hiding this comment.
I believe we don't need 2 of them:
-self.set_dash_test_params(2, 1)
+self.set_dash_test_params(1, 0)
knst
approved these changes
Dec 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
rpc_manuthis failing in ~50% cases locally because we still use legacy pubkeys (not in 100% cases because sometimes they look like basic ones). In CI it fails too but we retry failed tests a few times so it's less noticeable. Example of "unlucky" tests: https://gitlab.com/dashpay/dash/-/jobs/8613271300#L1867.#6467 follow-up
What was done?
Add another masternode after v19 activaition to actually use basic bls pubkey
How Has This Been Tested?
run tests
Breaking Changes
n/a
Checklist: