refactor: move all network operations out of CGovernanceManager

[UdjinM6]

Issue being fixed or feature implemented

Move all network operations from CGovernanceManager to the appropriate network layer classes (SyncManager and NetGovernance).

What was done?

Refactor only, see individual commits

How Has This Been Tested?

Run tests, sync gov data on mainnet node

Breaking Changes

n/a

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[coderabbitai]

Walkthrough

The changes decouple governance data collection from network I/O by replacing several network-performing methods with pure getters: SyncObjects → GetSyncableObjectInvs, SyncSingleObjVotes → GetSyncableVoteInvs, RequestGovernanceObject → GetVoteBloomFilter, and RequestOrphanObjects → GetOrphanVoteObjectHashes. ProcessVote now returns an output hashToRequest instead of issuing network requests directly. Callers in net_governance and sync_manager now perform network messaging and object requests using the returned data; SyncManager gained SendGovernanceObjectSyncRequest to centralize sending sync messages.

Sequence Diagram(s)

sequenceDiagram
    participant SyncMgr as SyncManager
    participant GovMgr as CGovernanceManager
    participant Connman as CConnman/Peers

    SyncMgr->>GovMgr: GetSyncableObjectInvs()
    GovMgr-->>SyncMgr: vector<CInv> (objects)
    SyncMgr->>Connman: Send SYNCSTATUSCOUNT (GOVOBJ)
    SyncMgr->>Connman: Relay invs for each CInv

Loading

sequenceDiagram
    participant Peer as RemotePeer
    participant NetGov as NetGovernance
    participant GovMgr as CGovernanceManager
    participant SyncMgr as SyncManager
    participant Connman as CConnman/Peers

    Peer->>NetGov: MNGOVERNANCEOBJECTVOTE (vote)
    NetGov->>GovMgr: ProcessVote(peer, vote, exception, hashToRequest)
    GovMgr-->>NetGov: bool accepted, hashToRequest (maybe zero)
    alt vote rejected && hashToRequest != 0
        NetGov->>SyncMgr: SendGovernanceObjectSyncRequest(peer, hashToRequest, useFilter=true)
        SyncMgr->>Connman: Push MNGOVERNANCESYNC (hashToRequest, bloom filter)
    end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title directly and accurately describes the main refactoring objective: moving network operations out of CGovernanceManager to appropriate network layer classes.
Description check	✅ Passed	The PR description clearly explains the refactoring objective, what was done, testing approach, and indicates no breaking changes, all of which align with the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[knst]

LGTM overall, consider further improvements (2 commits attached to my comments); nits are minor

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[knst]

LGTM 32b761b

[UdjinM6]

ping @PastaPastaPasta