Skip to content

test: increase v23 activation spork sync timeout #7326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thepastaclaw wants to merge 1 commit into from
Closed

test: increase v23 activation spork sync timeout #7326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/functional/test_framework/test_framework.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1560,7 +1560,7 @@ def activate_by_name(self, name, expected_activation_height=None, slow_mode=True
spork17_value = self.nodes[0].spork('show')['SPORK_17_QUORUM_DKG_ENABLED']
self.bump_mocktime(1)
self.nodes[0].sporkupdate("SPORK_17_QUORUM_DKG_ENABLED", 4070908800)
self.wait_for_sporks_same()
self.wait_for_sporks_same(timeout=60)

# mine blocks in batches
batch_size = 50 if not slow_mode else 10
Expand Down Expand Up @@ -1591,7 +1591,7 @@ def activate_by_name(self, name, expected_activation_height=None, slow_mode=True
# revert spork17 changes
self.bump_mocktime(1)
self.nodes[0].sporkupdate("SPORK_17_QUORUM_DKG_ENABLED", spork17_value)
self.wait_for_sporks_same()
self.wait_for_sporks_same(timeout=60)
Comment on lines 1563 to +1594
Copy link
Copy Markdown
Author

@thepastaclaw thepastaclaw May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 Nitpick: Timeout bump addresses symptom, not root cause of spork-sync flakiness

Doubling the timeout from 30s to 60s is an appropriate release-branch stabilization and is consistent with the prior fix cited in the PR description, so it is fine to merge as-is. However, the underlying reason spork propagation in activate_by_name() can exceed 30s on v23.1.x CI is still unexplained. If the same class of flake recurs at 60s, the next step should not be another timeout bump — instrumenting wait_for_sporks_same() to log which node lags and the diff from spork('show') at timeout would make the underlying mocktime/propagation issue diagnosable. Non-blocking.

source: ['claude']


def activate_v20(self, expected_activation_height=None):
self.activate_by_name('v20', expected_activation_height)
Expand Down
Loading