Skip to content

V0.12.1.x - dashified the about icons#759

Closed
taw00 wants to merge 1 commit into
dashpay:v0.12.1.xfrom
taw00:v0.12.1.x
Closed

V0.12.1.x - dashified the about icons#759
taw00 wants to merge 1 commit into
dashpay:v0.12.1.xfrom
taw00:v0.12.1.x

Conversation

@taw00
Copy link
Copy Markdown

@taw00 taw00 commented Apr 13, 2016

Swapped out some icons. For example, open dash-qt, go to "help" and "about dash" and note the "bitcoin" icon there now. This fixes that.

@UdjinM6
Copy link
Copy Markdown

UdjinM6 commented Apr 13, 2016

Nicely spotted, thanks!

Can you squash commits into one and push the clean one (-f) again pls?

@taw00
Copy link
Copy Markdown
Author

taw00 commented Apr 13, 2016

Googling. Not sure how to do that. Standby.

@taw00
Copy link
Copy Markdown
Author

taw00 commented Apr 13, 2016

Eegad... my repo is all hosed now. Hmm.

@taw00
Copy link
Copy Markdown
Author

taw00 commented Apr 13, 2016

Fixed... with @moocowmoo's help cuz I am git-challenged.

@UdjinM6
Copy link
Copy Markdown

UdjinM6 commented Apr 13, 2016

Looks good now, ACK a9a9c9a :)

@crowning-
Copy link
Copy Markdown

crowning- commented Apr 24, 2016

Unfortunately this change will (most probably) be superseeded by https://github.com/crowning-/dash/tree/UI_Icons because of #762.

Those black/transparent icons introduced by the Bitcoin-devs are almost invisible on some Linux flavors, and don't look good on other operating systems depending on the OS-version and/or chosen UI-theme of the operating system. No idea why they did this, especially why they did this only for a couple of icons and not ALL of them. Makes the look quite inconsistent.

I will create a pull request later today (with screenshots of the results) when my testing for OSX is done. We can discuss things there...

Edit: done, see #764

@UdjinM6
Copy link
Copy Markdown

UdjinM6 commented Apr 24, 2016

I agree with @crowning- - black icons look weird on default ubuntu scheme :( If I broke smth while Iwas merging bitcoin source and icons actually look good on linux for bitcoin - please, let me know. Otherwise I would prefer #764 over this one.

@eduffield222
Copy link
Copy Markdown

Closing due to duplication with #764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants