Assign app name in NetworkStyle::NetworkStyle()

[UdjinM6]

Fixes Splash Screen bug mentioned in #760 (comment)

[crowning-]

Okay, let's continue here:

Copy/Paste from #760:

Where do the orange icons in my screenshot in #760 come from? They are nowhere in our repository.
I can't get them away, even a hard-coded "QIcon icon = QIcon(":/icons/crownium/tx_input");" in TxViewDelegate (which should display the (existing) chrome-ish icons of that theme).

Does someone somewhere paint them, no matter which *.png are chosen?

[UdjinM6]

Ahh, I see.. That's because of the platform style - https://github.com/dashpay/dash/blob/v0.12.1.x/src/qt/platformstyle.cpp#L24-L28 - it colorizes icons for some and it doesn't for otheres. I'm not sure why you are expecting crownium theme to affect your overview though because it's clearly drkblue theme there.

[crowning-]

On Ubuntu 14.04 with Unity-desktop I ALWAYS get the orange icons, no matter which theme I load.
Looks ugly...

[crowning-]

Yep, I changed https://github.com/dashpay/dash/blob/v0.12.1.x/src/qt/platformstyle.cpp#L28 to "{"other", true, false, false}" and it worked as it should.
Shall I PR the change?

[UdjinM6]

Shall I PR the change?

Sure, why not :)

I guess there are more issues with coloring/icons however - there are no icons in menus on mac for example (and I'm dev-ing on mac) so smth might look ugly on ubuntu/windows. Can you do a quick check for this also?

[crowning-]

PR is done, see #762. There are some other issues unrelated to this one, like some icons being black in the menus on Ubuntu. They are probably just missing or wrongly referenced.
I'll create another PR once I find the time to fix those.

[UdjinM6]

They are probably just missing or wrongly referenced.

@crowning- I guess that most likely it's simply misuse (in terms of Dash-styling) of TextColorIcon() where it should be SingleColorIcon() instead.