Select nondenom first#78
Closed
UdjinM6 wants to merge 6 commits intodashpay:masterfrom
UdjinM6:select_nondenom_first
Closed
Select nondenom first#78UdjinM6 wants to merge 6 commits intodashpay:masterfrom UdjinM6:select_nondenom_first
UdjinM6 wants to merge 6 commits intodashpay:masterfrom
UdjinM6:select_nondenom_first
Conversation
Author
|
Ok, testnet is half-dead now ;) so I did few tests. Seems to work fine in terms of expected logic. However this brings darksend rounds calculations which can be quite expensive. Will rework. |
Author
|
|
It looks pretty good, can you make a merge request for the v0.11.0.x branch though? I'd rather not push out another version for 10. unless we have to |
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jul 17, 2019
* News URL updated * QCalendarView styles modified * Replace version of the wallet
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
SNAP: Trigger build of candidate (stable) branch
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
Fix multilib package, cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select "regular" funds first when user unchecked "Darksend" checkbox on "Send" tab (function SelectCoinsMinConf is used only in that case right now). This should help to preserve already anonymized funds.
NOTE: It's straight forward and unoptimized. Not tested as testnet is dead right now.