Merge Bitpay's version of Bitcoin Core (additional indexes)#914
Merged
Conversation
Adds a configuration option for addressindex to search for txids by address. Includes an additional rpc method for getting the txids for an address.
fixes a sorting issue when iterating over keys
It's only necessary to sort when combining results for several addresses as the results are already in order from the database.
There was a bug where the spending address index could have the same key as the receiving address index if the input and output indexes matched. This lead to the output always overwriting the input index leading to incorrect balances with missing spent amounts. This patch separates the two so that they have unique keys so balances will be correctly calculated.
There was an issue where getblockhashes wouldn't work from bitcoin-cli as the two params would be strings instead of integers. This fixes that issue, and will parse the first param as JSON for other addressindex related rpc methods.
for the purposes of secondary sorting by block order
0.12.1 bitcore
fixes a minor bug where iteration would not end when there are matching hashes for a p2sh and p2pkh address, and would return results for both addresses
fixes a bug that would happen when an output would match an input with the same address and index, and would lead to the outputs not appearing in results.
…ests mempool address index bug fixes
rpc: add input confirmations to getrawtransaction
main: do not log error when spent info not found
Revert "rpc: add input confirmations to getrawtransaction"
Resolved Conflicts: .travis.yml (ignoring changes, leaving dash version) src/Makefile.am src/main.cpp src/main.h src/rpcclient.cpp src/rpcserver.cpp src/script/script.cpp src/script/script.h
|
Maybe we need a compiler switch (like DISABLE_WALLET) to guard these features |
| { "blockchain", "gettxoutsetinfo", &gettxoutsetinfo, true }, | ||
| { "blockchain", "verifychain", &verifychain, true }, | ||
| { "blockchain", "invalidateblock", &invalidateblock, true }, | ||
| { "blockchain", "reconsiderblock", &reconsiderblock, true }, |
There was a problem hiding this comment.
I guess you don't wont to remove these
Author
There was a problem hiding this comment.
We somehow missed bitcoin@5ebe095 so I resolved it this way.
|
Is this still WIP? |
UdjinM6
changed the title
Author
|
Changed title ;) This merge is kind of huge so I still would like to hear any comments and/or (ut/n)ACKs from @evan82 though. |
|
Yep, i agree - waiting for comments and/or (ut/n)ACKs from @evan82 :) |
|
This is insanely useful and built entirely separate from core... merged 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.travis.yml (ignoring changes, keeping dash version)
src/Makefile.am
src/main.cpp
src/main.h
src/rpcclient.cpp
src/rpcserver.cpp
src/script/script.cpp
src/script/script.h
qa/rpc-tests/addressindex.py
qa/rpc-tests/spentindex.py
qa/rpc-tests/txtindex.py
src/test/script_P2PKH_tests.cpp