Skip to content

docs(dip0023): adjustment of DIP-0023 #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thephez merged 3 commits into from
Jul 25, 2023
Merged

docs(dip0023): adjustment of DIP-0023 #138

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75d54fc
docs(dip0023): renamed version to versionBit in MnEhf Signal to avoid…
knst Jul 25, 2023
e3d3ba1
docs(dip0023): explicitely specify size of MnEHF Signal - it's not va…
knst Jul 25, 2023
eb282b4
docs(dip-0023): update version size from 2 bytes to only 1 - it seems…
knst Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dip-0023.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,16 @@ The `mnhfsignal` message should look like:

| Field | Type | Size | Description |
|-|-|-|-|
| version | uint8_t | 1 | The version bits associated with the hard fork |
| versionBit | uint8_t | 1 | The version bits associated with the hard fork |
| quorumHash | uint256 | 32 | Hash of the quorum signing this message |
| sig | CBLSSig | 96 | BLS signature on `version` by a public key associated with the quorum referenced by `quorumHash` |

The payload of the Masternode Hard Fork Signalling Transaction (the new special transaction with type=7) should have the following format:

| Field | Type | Size | Description |
|-|-|-|-|
| version | uint_16 | 2 | Commitment special transaction version number. Currently set to 1. Please note that this is not the same as the version field of the `mnhfsignal` message |
| commitment | mnhfsignal | Variable | This equals the payload of the `mnhfsignal` P2P message
| version | uint_8 | 1 | Commitment special transaction version number. Currently set to 1. Please note that this is not the same as the version field of the `mnhfsignal` message |
| commitment | mnhfsignal | 129 | This equals the payload of the `mnhfsignal` P2P message

**Stage 2:** Once this `mnhfsignal` message has been mined, two parameters are set:
`masternode_activation_height` and `min_activation_height`. The cycle beginning at
Expand Down