Update DIPs regarding use of BLS12-381-reversed#25
Conversation
Also add the "Size" column to all serialization specs to align with other DIPs.
| | ipAddress | byte[] | 16 | IPv6 address in network byte order. Only IPv4 mapped addresses are allowed (to be extended in the future) | | ||
| | port | uint_16 | 2 | Port (network byte order) | | ||
| | keyIDOperator | CKeyID | 20 | The operators public key hash | | ||
| | pubKeyOperator | CKeyID | 48 | The operators public key | |
| It is necessary to serialize BLS primitives into a byte representation so that they can be used inside other serialized data structures. How this is performed depends on the curves and libraries used. This has not been defined yet and this document will be updated later. | ||
| It is necessary to serialize BLS primitives into a byte representation so that they can be used inside other serialized data structures. | ||
| The serialization format is described in the Chia [bls-signatures](https://github.com/Chia-Network/bls-signatures/blob/master/SPEC.md) | ||
| repository. |
There was a problem hiding this comment.
Is there a reason for the line breaks here?
There was a problem hiding this comment.
It's very hard to read/edit otherwise in my editor. In Markdown, single-newlines are ignored when rendered, so it's the same as if there was no newline.
I'd suggest to limit line width in the future when we create DIPs to make editing/reading the plain Markdown easier.
There was a problem hiding this comment.
We have this problem in all DIPs and nearly all paragraphs are in a single line...
There was a problem hiding this comment.
I don't see it as a "problem" since editors can be made to soft fold, but, I also understand and think if we do this then let's set at something standard like 72 or 80 and hard-wrap at that then.
|
|
||
| The ProRegTx contains 3 public key IDs, which represent 3 different roles in the masternode and define update and voting rights. A "public key ID" refers to the hash160 of an ECDSA public key. These are: | ||
| The ProRegTx contains 2 public key IDs and one BLS public key, which represent 3 different roles in the masternode and define update and voting rights. | ||
| A "public key ID" refers to the hash160 of an ECDSA public key. The keys are: |
There was a problem hiding this comment.
Same question about line breaks as below
|
Is this ready for merge? No ACKs yet... |
|
Only question I see is whether we leave the line breaks or remove them. Content looks fine. |
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
ACK
I don't have a strong opinion about line breaks, I'm fine with either one.
|
IMHO we should leave them and in the future change all paragraphs to be multiline. As explained, it doesn't change how it is rendered but makes live a lot easier when editing these files |
|
I missed your comment several days ago @codablock. I'm fine with it, just wondered why you left it that way (and now I saw the explanation). |
4 participants
See individual commits.
Closes #23