feat: insert if not exists#11
Merged
Merged
Conversation
iammadab
requested review from
QuantumExplorer and
fominok
and removed request for
QuantumExplorer
fominok
approved these changes
Dec 20, 2021
Co-authored-by: Evgeny Fomin <fominok@hotmail.com>
QuantumExplorer
approved these changes
Dec 21, 2021
QuantumExplorer
added a commit
that referenced
this pull request
Mar 9, 2026
Finding #11 noted that child_aggregate_sum_data_as_i64() and similar methods silently return 0 when encountering mismatched AggregateData variants (e.g. Count under a SummedMerkNode parent). This is a false positive because GroveDB enforces homogeneous TreeFeatureType within each Merk tree via get_feature_type(), making cross-type mixing impossible during normal operation. Added debug_assert! guards to catch type mismatches during testing (zero cost in release builds) and comprehensive documentation explaining the type safety invariant on all four affected methods: child_aggregate_sum_data_as_i64, child_aggregate_count_data_as_u64, child_aggregate_sum_data_as_i128, and aggregate_data. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
QuantumExplorer
added a commit
that referenced
this pull request
Mar 9, 2026
* docs: document cross-type aggregate safety and add debug assertions Finding #11 noted that child_aggregate_sum_data_as_i64() and similar methods silently return 0 when encountering mismatched AggregateData variants (e.g. Count under a SummedMerkNode parent). This is a false positive because GroveDB enforces homogeneous TreeFeatureType within each Merk tree via get_feature_type(), making cross-type mixing impossible during normal operation. Added debug_assert! guards to catch type mismatches during testing (zero cost in release builds) and comprehensive documentation explaining the type safety invariant on all four affected methods: child_aggregate_sum_data_as_i64, child_aggregate_count_data_as_u64, child_aggregate_sum_data_as_i128, and aggregate_data. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: remove debug_assert! guards from cross-type aggregate branches These branches are unreachable due to GroveDB's type enforcement (homogeneous TreeFeatureType within each Merk tree). The doc comments already explain why, making the debug_asserts unnecessary noise. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: fix truncated doc comment on child_aggregate_sum_data_as_i128 Remove stray trailing "The" left over from previous edit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insert an element at a path only if that path is empty