feat: subtree pairs iterator#12
Merged
Merged
Conversation
9bd3b16 to
faae8ae
Compare
QuantumExplorer
approved these changes
Dec 26, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
Path compression
It alters how path compression works, previously collisions may occur for cases like
[a, ab] vs [aa, b], also subtree keys shared the same prefix as parent trees which is harmful for iteration over subtree elements as there is no way to find out where to stop, now they're not.New path compression algorithm (for subtree key):
Subtree elements' keys use the same approach, but appending their key after hashing happened, this way their order is preserved and they're located sequentially in DB.
Subtree elements iterator
This allows for a given subtree to iterate over key-value pairs sorted by key, values are
Elementobject