feat: node.js neon bindings#8
Merged
Merged
Conversation
fominok
approved these changes
Dec 17, 2021
| let js_key = cx.argument::<JsBuffer>(1)?; | ||
| let js_callback = cx.argument::<JsFunction>(2)?.root(&mut cx); | ||
|
|
||
| let path = converter::js_array_of_buffers_to_vec(js_path, &mut cx)?; |
Contributor
There was a problem hiding this comment.
perhaps we need to represent paths as a continuous memory location sometime, otherwise we need to do such acrobatics
Contributor
Author
There was a problem hiding this comment.
@fominok It depends, I think from the Rust perspective it looks alright, otherwise you'll have to parse continuous memory to get path fragments for it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Add neon bindings for node.js to use it with the current implementation of the js-drive
What was done?
How Has This Been Tested?
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only