Skip to content

chore(platform): bump rust-dashcore version#2549

Merged
QuantumExplorer merged 1 commit into
v2.0-devfrom
chore/bump-rust-dashcore-version
Apr 16, 2025
Merged

chore(platform): bump rust-dashcore version#2549
QuantumExplorer merged 1 commit into
v2.0-devfrom
chore/bump-rust-dashcore-version

Conversation

@pauldelucia
Copy link
Copy Markdown
Member

@pauldelucia pauldelucia commented Apr 16, 2025

Issue being fixed or feature implemented

New rust-dashcore version changes value_sat in GetRawTransactionResultVout and GetRawTransactionResultVin from u32, which was incorrect and causing issues, to u64.

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Updated several dependencies to newer versions for improved stability and compatibility.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2025

Walkthrough

This change updates the versions of the dashcore and dashcore-rpc dependencies across several Rust package manifests. Specifically, the dashcore crate is updated in the rs-dpp package, while the dashcore-rpc crate is updated in the rs-drive-abci, rs-sdk, and simple-signer packages, all moving from version v0.39.3 to v0.39.5. Additionally, the log crate in rs-dpp's development dependencies is updated from 0.4.22 to 0.4.27. No changes to public APIs or code logic are included.

Changes

Files Change Summary
packages/rs-dpp/Cargo.toml Updated dashcore dependency from v0.39.3 to v0.39.5; updated log dev-dependency from 0.4.22 to 0.4.27.
packages/rs-drive-abci/Cargo.toml,
packages/rs-sdk/Cargo.toml,
packages/simple-signer/Cargo.toml
Updated dashcore-rpc dependency from v0.39.3 to v0.39.5.

Possibly related PRs

Suggested labels

cleanup

Suggested reviewers

  • QuantumExplorer

Poem

Hopping through the crates with glee,
Dependencies fresh as they can be!
From v0.39.3 to .5 we leap,
Ensuring our builds are shiny and neat.
With logs updated and code in sync,
This bunny’s proud—what do you think?
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94a9fd5 and 661221c.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • packages/rs-dpp/Cargo.toml (2 hunks)
  • packages/rs-drive-abci/Cargo.toml (1 hunks)
  • packages/rs-sdk/Cargo.toml (1 hunks)
  • packages/simple-signer/Cargo.toml (1 hunks)
🔇 Additional comments (5)
packages/rs-dpp/Cargo.toml (2)

31-31: Dependency version bump is correct and necessary.

The update to dashcore v0.39.5 is appropriate to address the field type fix. No issues found.


74-74: Minor dev-dependency update is safe.

The log crate update to 0.4.27 is a routine maintenance change and poses no risk.

packages/rs-drive-abci/Cargo.toml (1)

31-31: Dependency version bump is correct and necessary.

The update to dashcore-rpc v0.39.5 is appropriate and aligns with the fix for the field type. No issues found.

packages/rs-sdk/Cargo.toml (1)

41-41: Dependency version bump is correct and necessary.

The update to dashcore-rpc v0.39.5` is appropriate and required for the field type fix. No issues found.

packages/simple-signer/Cargo.toml (1)

11-11: Dependency version bump is correct and necessary.

The update to dashcore-rpc v0.39.5 is appropriate and required for the field type fix. No issues found.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@QuantumExplorer QuantumExplorer changed the title chore: bump rust-dashcore version chore(platform): bump rust-dashcore version Apr 16, 2025
@QuantumExplorer QuantumExplorer added this to the v2.0.0 milestone Apr 16, 2025
@QuantumExplorer QuantumExplorer merged commit 2a854e6 into v2.0-dev Apr 16, 2025
125 of 127 checks passed
@QuantumExplorer QuantumExplorer deleted the chore/bump-rust-dashcore-version branch April 16, 2025 13:15
@coderabbitai coderabbitai Bot mentioned this pull request Sep 24, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants