Skip to content

refactor(sdk): set group info for config update transition#2603

Merged
QuantumExplorer merged 2 commits into
v2.0-devfrom
feat/group-action-for-config-update
May 13, 2025
Merged

refactor(sdk): set group info for config update transition#2603
QuantumExplorer merged 2 commits into
v2.0-devfrom
feat/group-action-for-config-update

Conversation

@pauldelucia
Copy link
Copy Markdown
Member

@pauldelucia pauldelucia commented May 12, 2025

Issue being fixed or feature implemented

Group info was handled different in config update than other rs-sdk transition builders.

What was done?

Removed using_group_info from the builder constructor, and add with_using_group_info function.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • New Features
    • Enhanced the token configuration update process with a new option for specifying group information during updates.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2025

Walkthrough

The TokenConfigUpdateTransitionBuilder constructor was changed to remove the using_group_info parameter and initialize it as None by default. A new method with_using_group_info was added to set this field after construction, improving the builder's configuration pattern.

Changes

File(s) Change Summary
packages/rs-sdk/src/platform/transition/fungible_tokens/config_update.rs Removed using_group_info parameter from new constructor; added with_using_group_info builder method.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Builder as TokenConfigUpdateTransitionBuilder

    Caller->>Builder: new(data_contract, token_position, owner_id, update_token_configuration_item)
    Builder-->>Caller: returns Builder instance with using_group_info = None
    Caller->>Builder: with_using_group_info(group_info)
    Builder-->>Caller: returns updated Builder instance with using_group_info = Some(group_info)
Loading

Possibly related PRs

Suggested reviewers

  • shumkov

Poem

A builder hops along the code,
With group info now bestowed.
Fluent fields, transitions bright,
Hop by hop, the config’s right.
🐇✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92cb324 and ff0fac7.

📒 Files selected for processing (1)
  • packages/rs-sdk/src/platform/transition/fungible_tokens/config_update.rs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/rs-sdk/src/platform/transition/fungible_tokens/config_update.rs
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Rust packages (dash-sdk) / Unused dependencies
  • GitHub Check: Rust packages (dash-sdk) / Check each feature
  • GitHub Check: Rust packages (dash-sdk) / Tests
  • GitHub Check: Rust packages (dash-sdk) / Linting
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build JS packages / Build JS
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pauldelucia pauldelucia changed the title feat(rs-sdk): add group info setter function to config update transition feat(sdk): add group info setter function to config update transition May 12, 2025
@pauldelucia pauldelucia changed the title feat(sdk): add group info setter function to config update transition refactor(sdk): set group info for config update transition May 12, 2025
@QuantumExplorer QuantumExplorer added this to the v2.0.0 milestone May 13, 2025
@QuantumExplorer QuantumExplorer merged commit be46790 into v2.0-dev May 13, 2025
26 of 29 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/group-action-for-config-update branch May 13, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants