Skip to content

fix(drive): verification of token purchase can not verify the purchase cost as this can be lower than the agreed price #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 5 commits into from
May 19, 2025
Merged

fix(drive): verification of token purchase can not verify the purchase cost as this can be lower than the agreed price #2617

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad419c5
fix(drive): price paid is unknown for direct token purchase
pauldelucia May 19, 2025
0788757
added an extra verification
QuantumExplorer May 19, 2025
b037ab6
Merge branch 'v2.0-dev' into fix/direct-purchase-proof
QuantumExplorer May 19, 2025
790162c
fix
QuantumExplorer May 19, 2025
436ed8a
Merge branch 'fix/direct-purchase-proof' of github.com:dashpay/platfo…
QuantumExplorer May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...ive/src/verify/state_transition/verify_state_transition_was_executed_with_proof/v0/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,17 @@ impl Drive {
Some(vec!["destroyedAmount", "note"])
}
TokenTransition::Claim(_) => Some(vec!["amount"]),
TokenTransition::DirectPurchase(_) => {
let purchase_cost: Credits =
document.properties().get_integer("purchaseCost")?;
let agreed_to_purchase_cost: Credits = expected_document
.properties()
.get_integer("purchaseCost")?;
if purchase_cost > agreed_to_purchase_cost {
return Err(Error::Proof(ProofError::UnexpectedResultProof(format!("proof of state transition execution showed a purchase price of {}, whereas we only agreed to {}, state transition is [{}]", purchase_cost, agreed_to_purchase_cost, token_transition))));
}
Some(vec!["purchaseCost"])
}
TokenTransition::Burn(_)
| TokenTransition::Mint(_)
| TokenTransition::Freeze(_)
Expand Down
Loading