Skip to content

feat(dpp)!: disable changes to perpetual distribution in token configuration #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 2 commits into from
May 22, 2025
Merged

feat(dpp)!: disable changes to perpetual distribution in token configuration #2627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ce0ecf
feat!: disable changes to perpetual distribution in token configuration
QuantumExplorer May 22, 2025
95609e0
small fix
QuantumExplorer May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/rs-dpp/src/errors/consensus/basic/unsupported_feature_error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use thiserror::Error;
#[derive(
Error, Debug, Clone, PartialEq, Eq, Encode, Decode, PlatformSerialize, PlatformDeserialize,
)]
#[error("feature {feature_name} is not supported in version {current_protocol_version}")]
#[error("feature {feature_name} is not supported. This validation was done in protocol version {current_protocol_version}")]
#[platform_serialize(unversioned)]
pub struct UnsupportedFeatureError {
/*
Expand Down
2 changes: 1 addition & 1 deletion ...ch_transition/batched_transition/token_config_update_transition/validate_structure/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ impl TokenConfigUpdateTransitionStructureValidation for TokenConfigUpdateTransit
.batch_state_transition
.token_config_update_transition_structure_validation
{
0 => self.validate_structure_v0(),
0 => self.validate_structure_v0(platform_version),
version => Err(ProtocolError::UnknownVersionMismatch {
method: "TokenConfigUpdateTransition::validate_structure".to_string(),
known_versions: vec![0],
Expand Down
27 changes: 24 additions & 3 deletions ...transition/batched_transition/token_config_update_transition/validate_structure/v0/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use platform_version::version::PlatformVersion;
use crate::consensus::basic::token::{InvalidTokenConfigUpdateNoChangeError, InvalidTokenNoteTooBigError, TokenNoteOnlyAllowedWhenProposerError};
use crate::consensus::basic::BasicError;
use crate::consensus::basic::{BasicError, UnsupportedFeatureError};
use crate::consensus::ConsensusError;
use crate::data_contract::associated_token::token_configuration_item::TokenConfigurationChangeItem;
use crate::state_transition::batch_transition::token_config_update_transition::v0::v0_methods::TokenConfigUpdateTransitionV0Methods;
Expand All @@ -11,10 +12,16 @@ use crate::state_transition::batch_transition::token_base_transition::token_base
use crate::state_transition::batch_transition::token_base_transition::v0::v0_methods::TokenBaseTransitionV0Methods;

pub(super) trait TokenConfigUpdateTransitionStructureValidationV0 {
fn validate_structure_v0(&self) -> Result<SimpleConsensusValidationResult, ProtocolError>;
fn validate_structure_v0(
&self,
platform_version: &PlatformVersion,
) -> Result<SimpleConsensusValidationResult, ProtocolError>;
}
impl TokenConfigUpdateTransitionStructureValidationV0 for TokenConfigUpdateTransition {
fn validate_structure_v0(&self) -> Result<SimpleConsensusValidationResult, ProtocolError> {
fn validate_structure_v0(
&self,
platform_version: &PlatformVersion,
) -> Result<SimpleConsensusValidationResult, ProtocolError> {
if matches!(
self.update_token_configuration_item(),
TokenConfigurationChangeItem::TokenConfigurationNoChange
Expand All @@ -26,6 +33,20 @@ impl TokenConfigUpdateTransitionStructureValidationV0 for TokenConfigUpdateTrans
));
}

if matches!(
self.update_token_configuration_item(),
TokenConfigurationChangeItem::PerpetualDistribution(_)
) {
return Ok(SimpleConsensusValidationResult::new_with_error(
ConsensusError::BasicError(BasicError::UnsupportedFeatureError(
UnsupportedFeatureError::new(
"of changing perpetual distribution".to_string(),
platform_version.protocol_version,
),
)),
));
}

if let Some(public_note) = self.public_note() {
if public_note.len() > MAX_TOKEN_NOTE_LEN {
return Ok(SimpleConsensusValidationResult::new_with_error(
Expand Down