fix: fixes issue #2653 Cannot decode DataContractCreateV1 with WASM-DPP

[QuantumExplorer]

Summary by CodeRabbit

• New Features

  • Added support for specifying a protocol version when retrieving a Data Contract from create or update transitions.

• Bug Fixes

  • Improved error handling when retrieving a Data Contract, returning errors instead of causing application crashes.

• Tests

  • Added a test to verify consistent behavior when retrieving a Data Contract with or without a protocol version.

[coderabbitai]

Walkthrough

The changes update methods for retrieving data contracts in WASM bindings to support protocol version awareness. Method signatures now accept an optional protocol version, use it to resolve the platform version, and return a Result for error handling. Corresponding unit tests are updated to verify this new behavior.

Changes

File(s)	Change Summary
.../src/data_contract/data_contract.rs	Renamed and refactored method to accept a platform version parameter instead of using a default.
.../src/data_contract/state_transition/data_contract_create_transition/mod.rs .../data_contract_update_transition/mod.rs	Updated get_data_contract methods: now accept optional protocol version, use platform version, and return Result instead of panicking.
.../test/unit/dataContract/stateTransition/DataContractCreateTransition/DataContractCreateTransition.spec.js	Added a test verifying getDataContract with a protocol version returns the expected data contract.

Sequence Diagram(s)

sequenceDiagram
    participant JS as JavaScript
    participant WASM as WASM Bindings
    participant Platform as PlatformVersion

    JS->>WASM: get_data_contract(protocol_version?)
    WASM->>Platform: resolve PlatformVersion (from protocol_version or latest)
    WASM->>WASM: try_from_serialization_format_with_platform_version(data, false, platform_version)
    WASM-->>JS: Result<DataContractWasm, JsValue>

Loading

Suggested reviewers

• shumkov

Poem

In the warren of code, a change takes flight,
Now contracts know which version is right.
No more panic, just graceful return,
With protocol wisdom at every turn.
A test hops in, to check the way—
The platform’s future, bright as day!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64fefde and e311c44.

📒 Files selected for processing (2)

• packages/wasm-dpp/src/data_contract/state_transition/data_contract_create_transition/mod.rs (1 hunks)
• packages/wasm-dpp/src/data_contract/state_transition/data_contract_update_transition/mod.rs (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• packages/wasm-dpp/src/data_contract/state_transition/data_contract_create_transition/mod.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/wasm-dpp/src/data_contract/state_transition/data_contract_update_transition/mod.rs

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: Rust packages (wasm-dpp) / Tests
• GitHub Check: Rust packages (wasm-dpp) / Linting
• GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
• GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
• GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
• GitHub Check: Build JS packages / Build JS

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.