build: update rust to 1.89#2755
Conversation
WalkthroughBumps the Rust toolchain/workspace version from 1.85 to 1.89 across Cargo.toml, rust-toolchain.toml, and README.md, and adds a trailing comma to the workspace members array in Cargo.toml. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
rust-toolchain.toml (1)
1-5: Consider adding rustfmt/clippy components for smoother onboardingMany contributors rely on them; adding components avoids “component not available” hiccups in CI/local.
Apply if desired:
[toolchain] # Rust version the same as in /README.md channel = "1.89" -targets = ["wasm32-unknown-unknown"] +targets = ["wasm32-unknown-unknown"] +components = ["rustfmt", "clippy"]README.md (1)
53-53: Doc bump to Rust 1.89 is consistent; tiny wording tweak recommendedSince rust-toolchain.toml pins 1.89.x, consider clarifying users don’t need to manage versions manually.
- - [rust](https://www.rust-lang.org/tools/install) v1.89+, with wasm32 target (`rustup target add wasm32-unknown-unknown`) + - [rustup](https://www.rust-lang.org/tools/install) (repo pins Rust 1.89 via rust-toolchain); add wasm32 target (`rustup target add wasm32-unknown-unknown`)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
Cargo.toml(1 hunks)README.md(1 hunks)rust-toolchain.toml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-10-18T15:39:51.172Z
Learnt from: lklimek
PR: dashpay/platform#2254
File: packages/rs-sdk/src/sdk.rs:585-585
Timestamp: 2024-10-18T15:39:51.172Z
Learning: The 'platform' project uses Rust version 1.80, so code in 'packages/rs-sdk' can use features available in Rust 1.80, such as the `abs_diff()` method.
Applied to files:
Cargo.toml
🪛 LanguageTool
README.md
[grammar] ~53-~53: There might be a mistake here.
Context: ...stup target add wasm32-unknown-unknown`) - [protoc - protobuf compiler](https://gith...
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust crates security audit
🔇 Additional comments (2)
rust-toolchain.toml (1)
3-3: Toolchain bump to 1.89 looks goodMatches README/Cargo changes.
Cargo.toml (1)
37-38: Trailing comma in workspace members is fineNo functional impact; aligns with common formatting.
|
|
||
| rust-version = "1.85" | ||
|
|
||
| rust-version = "1.89" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
MSRV raised to 1.89 — verify CI and per-crate overrides
Ensure CI/tooling (e.g., Docker images, actions, Makefiles) don’t pin older Rust, and that no crate overrides rust-version inconsistently.
Run to spot lingering pins:
🏁 Script executed:
#!/bin/bash
# Find old pins/usages
rg -nP '\b1\.85\b|\bstable-1\.85\b|rustc 1\.85' -g '!**/target/**' -S
# List any per-crate rust-version overrides
rg -nP '^\s*rust-version\s*=\s*".+?"' -g '!**/target/**' -S
# Check CI/tooling references
fd -H tests.yml .github | xargs rg -nP '\b(1\.85|1\.89)\b' -S
fd -H Dockerfile | xargs rg -nP '\b(1\.85|1\.89)\b' -SLength of output: 456
Per-crate MSRV override needs update
packages/wasm-drive-verify/Cargo.toml (line 6) still pins rust-version = "1.74" — bump to "1.89" or remove the override to match the workspace MSRV. No CI or Dockerfile references to 1.85 remain.
🤖 Prompt for AI Agents
In packages/wasm-drive-verify/Cargo.toml around line 6, the per-crate MSRV is
pinned to rust-version = "1.74" which conflicts with the workspace MSRV of 1.89;
update that rust-version entry to "1.89" (or remove the rust-version override
entirely) so the crate matches the workspace MSRV, and scan other crate
Cargo.toml files to ensure no remaining per-crate overrides still reference
older Rust versions.
2 participants
Issue being fixed or feature implemented
Dashcore v0.40-dev requires newer rust version
What was done?
Update rust to 1.89
How Has This Been Tested?
GHA + cargo build
Breaking Changes
New Rust required to build, but we don't consider it breaking
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
Chores
Documentation