Skip to content

chore: update to groveDB 3.1#2808

Merged
QuantumExplorer merged 1 commit into
v2.1-devfrom
chore/updateGroveDB31
Oct 18, 2025
Merged

chore: update to groveDB 3.1#2808
QuantumExplorer merged 1 commit into
v2.1-devfrom
chore/updateGroveDB31

Conversation

@QuantumExplorer
Copy link
Copy Markdown
Member

@QuantumExplorer QuantumExplorer commented Oct 18, 2025

This doesn't actually change underlying grovedb. We just released the grovedb version that will be used.

Summary by CodeRabbit

  • Chores
    • Updated grovedb dependencies to version 3.1.0 across packages.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 18, 2025

Walkthrough

Migrates grovedb-related dependencies across two packages from git-based revisions to published version 3.1.0. Updates six grovedb crates in rs-drive and one in rs-platform-version, replacing explicit git references with uniform version specifications while preserving optional and default-features flags.

Changes

Cohort / File(s) Summary
rs-drive grovedb dependencies
packages/rs-drive/Cargo.toml
Updated six grovedb-related dependencies (grovedb, grovedb-costs, grovedb-path, grovedb-storage, grovedb-version, grovedb-epoch-based-storage-flags) from git revisions to version 3.1.0; preserved optional and default-features flags where applicable
rs-platform-version grovedb dependency
packages/rs-platform-version/Cargo.toml
Updated grovedb-version dependency from git revision to version 3.1.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 From git revisions we hop away,
To version 3.1.0 today!
Grovedb dependencies stand so tall,
Clean and versioned—best of all! 🌳✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "chore: update to groveDB 3.1" directly reflects the main change in the changeset, which involves updating groveDB and its related dependencies from git-based revisions to published versioned crates (version 3.1.0) across multiple Cargo.toml files. The title is concise, specific, and uses the conventional "chore:" prefix appropriately for a dependency update. It clearly conveys the primary change without vague terminology, making it easy for teammates reviewing the repository history to understand the purpose of this pull request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/updateGroveDB31

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6f9d9e and b6ea680.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • packages/rs-drive/Cargo.toml (1 hunks)
  • packages/rs-platform-version/Cargo.toml (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: QuantumExplorer
PR: dashpay/platform#2431
File: packages/rs-drive/Cargo.toml:55-60
Timestamp: 2025-01-19T07:36:46.042Z
Learning: The grovedb dependencies in packages/rs-drive/Cargo.toml and related files are intentionally kept at specific revisions rather than using the latest stable version, with plans to update them at a later time.
Learnt from: QuantumExplorer
PR: dashpay/platform#2257
File: packages/rs-drive-abci/src/mimic/test_quorum.rs:159-164
Timestamp: 2024-11-20T16:16:01.830Z
Learning: QuantumExplorer prefers not to receive auto-generated messages asking to post on social media.
📚 Learning: 2025-01-19T07:36:46.042Z
Learnt from: QuantumExplorer
PR: dashpay/platform#2431
File: packages/rs-drive/Cargo.toml:55-60
Timestamp: 2025-01-19T07:36:46.042Z
Learning: The grovedb dependencies in packages/rs-drive/Cargo.toml and related files are intentionally kept at specific revisions rather than using the latest stable version, with plans to update them at a later time.

Applied to files:

  • packages/rs-drive/Cargo.toml
  • packages/rs-platform-version/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
  • GitHub Check: Rust packages (dash-sdk) / Tests
  • GitHub Check: Rust packages (drive-abci) / Tests
  • GitHub Check: Rust packages (rs-dapi-client) / Tests
  • GitHub Check: Rust packages (drive) / Tests
  • GitHub Check: Rust packages (drive) / Unused dependencies
  • GitHub Check: Rust packages (drive) / Linting
  • GitHub Check: Rust packages (dapi-grpc) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Tests
  • GitHub Check: Rust packages (rs-sdk-ffi) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Rust packages (dpp) / Tests
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
  • GitHub Check: Build JS packages / Build JS
  • GitHub Check: Rust crates security audit
  • GitHub Check: Swift SDK and Example build (warnings as errors)
🔇 Additional comments (2)
packages/rs-platform-version/Cargo.toml (1)

14-14: Verify grovedb 3.1.0 is a published crate and check for breaking API changes.

The dependency has been updated from a git revision to a semantic version. Ensure grovedb-version 3.1.0 exists on crates.io and that no code changes are required to accommodate API differences.

packages/rs-drive/Cargo.toml (1)

55-60: Verify grovedb 3.1.0 version status and compatibility before merging.

All six grovedb crates report as available at version 3.1.0 via crates.io API; however, public documentation (docs.rs, GitHub releases) lists 3.0.0 as the latest version, with no 3.1.0 release found. This discrepancy requires clarification:

  • Confirm whether 3.1.0 is an official release or a pre-release/internal version
  • Verify this migration aligns with the intentional version-pinning strategy noted for grovedb dependencies (see PR feat(platform): proof verification for many queries and a few more queries #2431)
  • Ensure compilation and tests pass with 3.1.0 before merging
  • Validate that no breaking API changes in 3.1.0 require code modifications

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@QuantumExplorer QuantumExplorer merged commit e930105 into v2.1-dev Oct 18, 2025
93 of 95 checks passed
@QuantumExplorer QuantumExplorer deleted the chore/updateGroveDB31 branch October 18, 2025 09:47
@QuantumExplorer QuantumExplorer restored the chore/updateGroveDB31 branch October 20, 2025 11:24
@thephez thephez added this to the v2.1.0 milestone Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants