fix(sdk): remove Document fetch_many override referencing removed parse_proof#3179
Conversation
… parse_proof method The revert commit d820fe2 brought back a custom Document FetchMany::fetch_many implementation that called Sdk::parse_proof, which was removed in #3141. This caused compilation failures across dash-sdk, wasm-sdk, rs-sdk-ffi, and iOS builds. Remove the custom override entirely so the trait's default fetch_many_with_metadata_and_proof implementation (which correctly uses parse_proof_with_metadata_and_proof) is used instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ gRPC Query Coverage Report |
📝 WalkthroughWalkthroughThe pull request removes the async Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "a0d374aae45489d3b077919cf6e218d1affb8f94ae471234b76460fa96c46b4b"
)Xcode manual integration:
|
Issue being fixed or feature implemented
Fixes compilation failures introduced by revert commit d820fe2 (#3114) across multiple CI checks: dash-sdk linting/tests, wasm-sdk linting/tests, rs-sdk-ffi tests, iOS build, and check-each-feature.
What was done?
The revert commit d820fe2 brought back a custom
DocumentFetchMany::fetch_manyimplementation that calledSdk::parse_proof, which was removed in #3141. This caused compilation failures in all crates depending ondash-sdk.Removed the custom
fetch_manyoverride entirely. The trait's defaultfetch_many_with_metadata_and_proofimplementation (which correctly usesparse_proof_with_metadata_and_proof) handles this case identically.Also removed the now-unnecessary
#[async_trait::async_trait]attribute on the impl block, matching the convention of otherFetchManyimpls that don't override methods.How Has This Been Tested?
cargo check -p dash-sdkpassescargo clippy -p dash-sdkpasses with no warningsBreaking Changes
None. The default trait implementation provides the same behavior.
Checklist: