Skip to content

ci: exclude DPP state transition boilerplate from coverage #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 2 commits into from
Mar 17, 2026
Merged

ci: exclude DPP state transition boilerplate from coverage #3358

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a9e8c1
ci: exclude DPP state transition boilerplate from coverage
QuantumExplorer Mar 17, 2026
8c8ccf3
Merge branch 'v3.1-dev' into ci/codecov-exclude-dpp-boilerplate
QuantumExplorer Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,22 @@ ignore:
- "packages/wasm-sdk/**"
- "**/block_end/validator_set_update/v0/**"
- "**/block_end/validator_set_update/v1/**"
# Error type definitions — these are enum/struct declarations with Display/thiserror
# Error type definitions — enum/struct declarations with Display/thiserror
# derives, not logic that needs test coverage
- "packages/rs-drive/src/error/**"
- "packages/rs-drive-abci/src/error/**"
- "packages/rs-dpp/src/errors/**"
- "packages/rs-dpp/src/state_transition/errors/**"
# State transition boilerplate — trait interfaces, accessors, field constants,
# type metadata, version dispatch, and factory patterns
- "packages/rs-dpp/src/state_transition/traits/**"
- "packages/rs-dpp/src/state_transition/state_transitions/**/accessors/**"
Comment on lines +30 to +31
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Coverage exclusions are too broad and remove logic-heavy code from tracking.

Line 30 (traits/**), Line 31 (accessors/**), and Line 37 (state_transition_factory.rs) exclude files that contain executable logic (e.g., state_transition_witness_validation.rs:52-89, batch_transition/accessors/mod.rs:44-115, state_transition_factory.rs:8-20). This undermines coverage signal instead of only removing boilerplate.

Suggested config adjustment 
-  - "packages/rs-dpp/src/state_transition/traits/**"
-  - "packages/rs-dpp/src/state_transition/state_transitions/**/accessors/**"
   - "packages/rs-dpp/src/state_transition/state_transitions/**/fields.rs"
   - "packages/rs-dpp/src/state_transition/state_transitions/**/common_fields.rs"
   - "packages/rs-dpp/src/state_transition/state_transitions/**/types.rs"
   - "packages/rs-dpp/src/state_transition/state_transitions/**/version.rs"
   - "packages/rs-dpp/src/state_transition/state_transition_types.rs"
-  - "packages/rs-dpp/src/state_transition/state_transition_factory.rs"
+  # Keep logic-bearing modules covered; if needed, exclude only explicit
+  # boilerplate trait/accessor files after listing them individually.

Also applies to: 37-37

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.codecov.yml around lines 30 - 31, The coverage exclusions are too
broad—rules like excluding "traits/**", "state_transitions/**/accessors/**", and
the current exclusion for state_transition_factory.rs are hiding logic (e.g.,
state_transition_witness_validation.rs, batch_transition/accessors/mod.rs,
state_transition_factory.rs). Tighten the .codecov.yml patterns to only omit
true boilerplate/generated files (for example exclude specific filenames like
mod.rs or a generated/ folder) and remove the broad "traits/**" and
"accessors/**" patterns so that files containing logic such as
state_transition_witness_validation, batch_transition/accessors/mod.rs, and
state_transition_factory.rs remain tracked.

- "packages/rs-dpp/src/state_transition/state_transitions/**/fields.rs"
- "packages/rs-dpp/src/state_transition/state_transitions/**/common_fields.rs"
- "packages/rs-dpp/src/state_transition/state_transitions/**/types.rs"
- "packages/rs-dpp/src/state_transition/state_transitions/**/version.rs"
- "packages/rs-dpp/src/state_transition/state_transition_types.rs"
- "packages/rs-dpp/src/state_transition/state_transition_factory.rs"
# Generated gRPC bindings — no hand-written logic to test
- "packages/dapi-grpc/**"
# Data contract crates — these are JSON schema definitions with only
Expand Down
Loading