chore(swift-sdk): remove not planned to use tx module in swift-sdk#3425
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughRemoved incomplete transaction-related functionality from the Swift SDK, specifically the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Review complete (commit 051d126) |
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "29312c05a39d4a3eef295a894fb94ad0f5d14bbe2733dabfd307705ac42d4a45"
)Xcode manual integration:
|
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Clean removal of unused stub types. SDKTransactionBuilder and SDKBuiltTransaction were placeholder stubs — build() threw notImplemented. The actual send transaction implementation landed in PR #3130 via a different path (KeyWallet/Transaction). No FFI contracts affected since these types never crossed the Swift/Rust boundary. No issues.
Reviewed commit: 051d126
Removed Tx module in swift-sdk since we are not using it and transactions are being built with a single function call, not using a builder
Summary by CodeRabbit
Release Notes