Skip to content

chore(swift-sdk): remove not planned to use tx module in swift-sdk#3425

Merged
QuantumExplorer merged 1 commit into
v3.1-devfrom
chore/remove-tx-module
Apr 3, 2026
Merged

chore(swift-sdk): remove not planned to use tx module in swift-sdk#3425
QuantumExplorer merged 1 commit into
v3.1-devfrom
chore/remove-tx-module

Conversation

@ZocoLini
Copy link
Copy Markdown
Collaborator

@ZocoLini ZocoLini commented Apr 2, 2026

Removed Tx module in swift-sdk since we are not using it and transactions are being built with a single function call, not using a builder

Summary by CodeRabbit

Release Notes

  • Refactor
    • Removed unimplemented transaction builder functionality and related type definitions from the Swift SDK, including transaction builder class, input/output handling structures, and associated error types. This cleanup removes non-functional code.

@github-actions github-actions Bot added this to the v3.1.0 milestone Apr 2, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dfba555a-91bc-456b-9db6-2aea6ed3df05

📥 Commits

Reviewing files that changed from the base of the PR and between 5381e78 and 051d126.

📒 Files selected for processing (2)
  • packages/swift-sdk/Sources/SwiftDashSDK/Tx/TransactionBuilder.swift
  • packages/swift-sdk/Sources/SwiftDashSDK/Tx/TransactionTypes.swift
💤 Files with no reviewable changes (2)
  • packages/swift-sdk/Sources/SwiftDashSDK/Tx/TransactionTypes.swift
  • packages/swift-sdk/Sources/SwiftDashSDK/Tx/TransactionBuilder.swift

📝 Walkthrough

Walkthrough

Removed incomplete transaction-related functionality from the Swift SDK, specifically the SDKTransactionBuilder class with its nested structs and the SDKBuiltTransaction struct along with SDKTxError enum from the Tx module.

Changes

Cohort / File(s) Summary
Removed Transaction Types
packages/swift-sdk/Sources/SwiftDashSDK/Tx/TransactionBuilder.swift, packages/swift-sdk/Sources/SwiftDashSDK/Tx/TransactionTypes.swift
Deleted unimplemented transaction builder class and associated types, including SDKTransactionBuilder (with nested Input and Output structs), SDKBuiltTransaction, and SDKTxError enum. Total 74 lines removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Incomplete builders fade away,
Unimplemented code won't stay,
Transaction dreams once built so tall,
Now removed—no trace at all!
Cleaner code hops on with glee,

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: removal of the tx module from swift-sdk due to it not being planned for use.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-tx-module

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thepastaclaw
Copy link
Copy Markdown
Collaborator

thepastaclaw commented Apr 2, 2026

✅ Review complete (commit 051d126)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

✅ DashSDKFFI.xcframework built for this PR.

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "29312c05a39d4a3eef295a894fb94ad0f5d14bbe2733dabfd307705ac42d4a45"
)

Xcode manual integration:

  • Download 'DashSDKFFI.xcframework' artifact from the run link above.
  • Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
  • If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

Copy link
Copy Markdown
Collaborator

@thepastaclaw thepastaclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Clean removal of unused stub types. SDKTransactionBuilder and SDKBuiltTransaction were placeholder stubs — build() threw notImplemented. The actual send transaction implementation landed in PR #3130 via a different path (KeyWallet/Transaction). No FFI contracts affected since these types never crossed the Swift/Rust boundary. No issues.

Reviewed commit: 051d126

@QuantumExplorer QuantumExplorer merged commit 63f75a1 into v3.1-dev Apr 3, 2026
37 checks passed
@QuantumExplorer QuantumExplorer deleted the chore/remove-tx-module branch April 3, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants