Skip to content

fix(rs-scripts): remove redundant wildcard pattern blocking CI#3430

Merged
QuantumExplorer merged 1 commit into
v3.1-devfrom
fix/rs-scripts-clippy
Apr 3, 2026
Merged

fix(rs-scripts): remove redundant wildcard pattern blocking CI#3430
QuantumExplorer merged 1 commit into
v3.1-devfrom
fix/rs-scripts-clippy

Conversation

@QuantumExplorer
Copy link
Copy Markdown
Member

@QuantumExplorer QuantumExplorer commented Apr 3, 2026

Issue being fixed or feature implemented

Clippy rejects "auto" | _ in the decode-document match arm (wildcard_in_or_patterns), causing CI failure on every PR that includes the rs-scripts workspace (#3428, #3429, etc.).

What was done?

One-line fix: "auto" | __. The _ wildcard already covers "auto" and everything else.

How Has This Been Tested?

cargo clippy -p rs-scripts -- -D warnings passes.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

Summary by CodeRabbit

  • Refactor
    • Simplified internal command-line argument handling logic while preserving existing behavior.

Clippy rejects `"auto" | _` since `_` already covers all patterns.
This was blocking CI on all PRs that include the rs-scripts workspace.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added this to the v3.1.0 milestone Apr 3, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 3, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ed288098-31b3-4e22-b31b-a09e2a5138ee

📥 Commits

Reviewing files that changed from the base of the PR and between 7011b62 and 4c7145b.

📒 Files selected for processing (1)
  • packages/rs-scripts/src/bin/decode_document.rs

📝 Walkthrough

Walkthrough

The --format argument handling in decode_document.rs was refactored to consolidate pattern matching. The combined "auto" | _ branch was replaced with a simple _ catch-all, reducing redundancy while preserving the same behavior for fallback decoding logic.

Changes

Cohort / File(s) Summary
Command-line format handling simplification
packages/rs-scripts/src/bin/decode_document.rs
Simplified pattern matching for --format argument by removing the explicit "auto" case and consolidating logic into a single catch-all branch that handles all non-explicit values identically.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰✨ A rabbit hops through tangled code,
One line removed lightens the load,
Pattern matching made clean and bright,
Simpler logic, more concise—just right!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rs-scripts-clippy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@QuantumExplorer QuantumExplorer merged commit 7969880 into v3.1-dev Apr 3, 2026
4 of 7 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/rs-scripts-clippy branch April 3, 2026 17:45
@thepastaclaw
Copy link
Copy Markdown
Collaborator

thepastaclaw commented Apr 3, 2026

Review Gate

Commit: 4c7145b9

  • Debounce: 2m ago (need 30m)

  • CI checks: build failure: PR title

  • CodeRabbit review: comment found

  • Off-peak hours: peak window (5am-11am PT) — currently 10:46 AM PT Friday

  • Run review now (check to override)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants