Skip to content

fix(rs-sdk-ffi): zeroize private key arrays after use in crypto/signer FFI #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 2 commits into from
Apr 3, 2026
Merged

fix(rs-sdk-ffi): zeroize private key arrays after use in crypto/signer FFI #3433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf39d37
fix(rs-sdk-ffi): zeroize private key arrays after use in crypto/signe…
QuantumExplorer Apr 3, 2026
5351324
chore(rs-scripts): remove unused serde_json dependency
QuantumExplorer Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/rs-scripts/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,3 @@ base64 = "0.22"
chrono = "0.4"
hex = "0.4"
clap = { version = "4", features = ["derive"] }
serde_json = "1"
7 changes: 4 additions & 3 deletions packages/rs-sdk-ffi/src/crypto/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ use crate::{DashSDKError, DashSDKErrorCode, DashSDKResult};
use dash_sdk::dpp::dashcore::Network;
use dash_sdk::dpp::identity::KeyType;
use std::ffi::{c_char, CStr};
use zeroize::Zeroizing;

/// Validate that a private key corresponds to a public key using DPP's public_key_data_from_private_key_data
///
Expand Down Expand Up @@ -65,7 +66,7 @@ pub unsafe extern "C" fn dash_sdk_validate_private_key_for_public_key(
}
};

let mut key_array = [0u8; 32];
let mut key_array = Zeroizing::new([0u8; 32]);
key_array.copy_from_slice(&private_key_bytes);

// Parse key type
Expand Down Expand Up @@ -176,7 +177,7 @@ pub unsafe extern "C" fn dash_sdk_private_key_to_wif(
Network::Mainnet
};

let mut key_array = [0u8; 32];
let mut key_array = Zeroizing::new([0u8; 32]);
key_array.copy_from_slice(&private_key_bytes);
match dash_sdk::dpp::dashcore::PrivateKey::from_byte_array(&key_array, network) {
Ok(private_key) => {
Expand Down Expand Up @@ -244,7 +245,7 @@ pub unsafe extern "C" fn dash_sdk_public_key_data_from_private_key_data(
}
};

let mut key_array = [0u8; 32];
let mut key_array = Zeroizing::new([0u8; 32]);
key_array.copy_from_slice(&private_key_bytes);

// Parse key type
Expand Down
5 changes: 3 additions & 2 deletions packages/rs-sdk-ffi/src/signer_simple.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use dash_sdk::dpp::dashcore::Network;
use dash_sdk::dpp::identity::signer::Signer;
use dash_sdk::dpp::identity::{IdentityPublicKey, KeyType, Purpose, SecurityLevel};
use simple_signer::SingleKeySigner;
use zeroize::Zeroizing;

/// Create a signer from a private key
///
Expand All @@ -32,9 +33,9 @@ pub unsafe extern "C" fn dash_sdk_signer_create_from_private_key(
));
}

// Convert the pointer to an array
// Convert the pointer to an array (zeroized on drop to avoid key material lingering on stack)
let key_slice = std::slice::from_raw_parts(private_key, 32);
let mut key_array: [u8; 32] = [0; 32];
let mut key_array = Zeroizing::new([0u8; 32]);
key_array.copy_from_slice(key_slice);

// network won't matter here
Expand Down
Loading