Skip to content

fix(wallet-lib): fix broadcast retry not matching DAPI error message #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 1 commit into from
Apr 3, 2026
Merged

fix(wallet-lib): fix broadcast retry not matching DAPI error message #3434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions NIGHTLY_STATUS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,13 @@ These jobs only run on nightly if relevant files changed in the latest commit. T

### Test Suite: `bad-txns-inputs-missingorspent` (since ~Mar 16)

Two withdrawal-related tests fail because Core rejects a transaction whose inputs are missing or already spent. The local network starts and processes blocks normally -- the failure is specific to the withdrawal test scenario.
Seven tests fail because Core rejects faucet wallet funding transactions whose inputs are already in the mempool. The failures are in the Data Contract and Contacts test groups -- 1 `before all` hook failure cascades into 6 dependent Contacts tests.

- **63 tests pass**, 2 fail
- **65 tests pass**, 7 fail (1 Data Contract funding + 6 Contacts cascade)
Comment on lines +40 to +42
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Inconsistent test counts with line 21.

Line 21 still states "2 of 65 tests fail" while line 42 now says "65 tests pass, 7 fail". These should be reconciled to avoid confusion.

📝 Suggested fix for line 21 
-| [Test Suite](https://github.com/dashpay/platform/actions/workflows/tests-test-suite.yml) (`test:suite`) | **Failing** | 2 of 65 tests fail with `bad-txns-inputs-missingorspent`. See [known issues](`#test-suite-bad-txns-inputs-missingorspent-since-mar-16`). |
+| [Test Suite](https://github.com/dashpay/platform/actions/workflows/tests-test-suite.yml) (`test:suite`) | **Failing** | 7 of 72 tests fail with `bad-txns-inputs-missingorspent`. See [known issues](`#test-suite-bad-txns-inputs-missingorspent-since-mar-16`). |
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@NIGHTLY_STATUS.md` around lines 40 - 42, Update the inconsistent test summary
by replacing the outdated phrase "2 of 65 tests fail" with the current result
"65 tests pass, 7 fail (1 Data Contract funding + 6 Contacts cascade)" so the
line currently showing "2 of 65 tests fail" matches the detailed report that now
states "65 tests pass, 7 fail"; ensure the summary text exactly mirrors that
detailed status.

- Error: `InvalidRequestError: Transaction is rejected: bad-txns-inputs-missingorspent`
- **Root cause:** The wallet-lib retry logic at `broadcastTransaction.js:181` checks for `'invalid transaction: bad-txns-inputs-missingorspent'` but DAPI returns `'Transaction is rejected: bad-txns-inputs-missingorspent'` -- the retry never matches, so UTXO conflicts are not retried.
- **Not caused by** the `ssh2`/`nan` compilation warnings (those are non-fatal)
- **Fix:** PR #3434 updates the check to use `.includes('bad-txns-inputs-missingorspent')`

### Functional tests: long-standing flakiness

Expand Down
2 changes: 1 addition & 1 deletion packages/wallet-lib/src/types/Account/methods/broadcastTransaction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ async function broadcastTransaction(transaction, options = {
} catch (error) {
cancelMempoolSubscription();

if (error.message === 'invalid transaction: bad-txns-inputs-missingorspent') {
if (error.message && error.message.includes('bad-txns-inputs-missingorspent')) {
if (this.broadcastRetryAttempts === MAX_RETRY_ATTEMPTS) {
throw error;
}
Expand Down
Loading