Skip to content

test(dpp): improve coverage for document property serialization and encoding#3439

Merged
QuantumExplorer merged 1 commit into
v3.1-devfrom
test/dpp-property-serialization
Apr 7, 2026
Merged

test(dpp): improve coverage for document property serialization and encoding#3439
QuantumExplorer merged 1 commit into
v3.1-devfrom
test/dpp-property-serialization

Conversation

@QuantumExplorer
Copy link
Copy Markdown
Member

Summary

Adds 87 tests to the document property type module — the largest non-excluded file in rs-dpp (4647 lines).

Area Tests What's covered
encode/read round-trips 30 All integer types (required + optional paths), F64, Date, String, ByteArray
Object serialization 5 Nested fields, required/optional inner fields, missing required error
Tree key encode/decode 20 All types, boundary values (MIN/MAX), empty string sentinel
read_optionally_from 12 Optional markers, fixed-size ByteArray (20/32/36), variable ByteArray
min/max byte size 5 Object field summing, VariableTypeArray, Identifier
Marker verification 15 Non-required encoding prefix (0xFF) for all integer types

Test plan

  • cargo test -p dpp --lib -- property::tests passes (275 total)
  • cargo fmt --all clean
  • CI

🤖 Generated with Claude Code

…ncoding

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 7, 2026

Warning

Rate limit exceeded

@QuantumExplorer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 13 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 29 minutes and 13 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 50d03b1d-7162-488e-a27b-07588d4c8d70

📥 Commits

Reviewing files that changed from the base of the PR and between 8a83981 and 9a6ca1b.

📒 Files selected for processing (1)
  • packages/rs-dpp/src/data_contract/document_type/property/mod.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/dpp-property-serialization

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added this to the v3.1.0 milestone Apr 7, 2026
@thepastaclaw
Copy link
Copy Markdown
Collaborator

thepastaclaw commented Apr 7, 2026

⏳ Review in progress (commit 9a6ca1b)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 98.18689% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.72%. Comparing base (8a83981) to head (9a6ca1b).
⚠️ Report is 2 commits behind head on v3.1-dev.

Files with missing lines Patch % Lines
...pp/src/data_contract/document_type/property/mod.rs 98.18% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           v3.1-dev    #3439      +/-   ##
============================================
+ Coverage     80.66%   80.72%   +0.06%     
============================================
  Files          2852     2852              
  Lines        285371   286088     +717     
============================================
+ Hits         230190   230956     +766     
+ Misses        55181    55132      -49     
Components Coverage Δ
dpp 73.64% <98.18%> (+0.35%) ⬆️
drive 82.49% <ø> (ø)
drive-abci 86.70% <ø> (ø)
sdk 36.55% <ø> (ø)
dapi-client 79.06% <ø> (ø)
platform-version ∅ <ø> (∅)
platform-value 90.79% <ø> (ø)
platform-wallet 76.09% <ø> (ø)
drive-proof-verifier 55.26% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@QuantumExplorer QuantumExplorer merged commit 37ba4a1 into v3.1-dev Apr 7, 2026
39 checks passed
@QuantumExplorer QuantumExplorer deleted the test/dpp-property-serialization branch April 7, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants