ci: expand codecov exclusions for non-unit-testable code#3444
Conversation
Exclude entire crates and broad patterns of boilerplate code that inflate the coverage denominator without representing testable logic: - Whole-crate exclusions: rs-sdk, rs-dapi, rs-dapi-client, wasm-drive-verify, proc-macro crates, CLI tools, context provider, platform wallet - Accessor pattern: all **/accessors/** and **/accessors.rs across crates - Batch transition factories: signing boilerplate in document transitions - Proof verifier types/error definitions - JSON schema compatibility validator - Consolidated redundant individual file exclusions into broader patterns Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
⏳ Review in progress (commit 1c0d1e8) |
📝 WalkthroughWalkthroughUpdated Codecov configuration to replace specific coverage ignore patterns with broader crate-level exclusions for SDK, DAPI, and related packages, while expanding wildcard patterns for accessor-related files and adding new ignored directories for platform wallet and additional tooling components. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.codecov.yml (1)
55-60: Sanity-check the components that now point at ignored crates.
packages/rs-sdk/src/**,packages/rs-dapi-client/**, andpackages/rs-platform-wallet/src/**overlap thesdk,dapi-client, andplatform-walletcomponents declared below. Once CI finishes, please confirm Codecov does not turn those components into empty/N/A buckets; if it does, retarget or remove the matchingcomponent_managemententries.Also applies to: 101-102
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.codecov.yml around lines 55 - 60, The ignore globs packages/rs-sdk/src/**, packages/rs-dapi-client/**, and packages/rs-platform-wallet/src/** overlap the defined components sdk, dapi-client, and platform-wallet and may cause those components to become empty in Codecov; after CI runs, verify Codecov did not mark sdk, dapi-client, or platform-wallet as empty/N/A, and if it did, either remove or retarget the matching ignore globs (packages/rs-sdk/src/**, packages/rs-dapi-client/**, packages/rs-platform-wallet/src/**) or adjust the component_management entries for sdk, dapi-client, and platform-wallet so their source paths no longer conflict. Ensure the final .codecov.yml maps each component to non-ignored paths and re-run CI to confirm coverage buckets are populated.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.codecov.yml:
- Around line 55-60: The ignore globs packages/rs-sdk/src/**,
packages/rs-dapi-client/**, and packages/rs-platform-wallet/src/** overlap the
defined components sdk, dapi-client, and platform-wallet and may cause those
components to become empty in Codecov; after CI runs, verify Codecov did not
mark sdk, dapi-client, or platform-wallet as empty/N/A, and if it did, either
remove or retarget the matching ignore globs (packages/rs-sdk/src/**,
packages/rs-dapi-client/**, packages/rs-platform-wallet/src/**) or adjust the
component_management entries for sdk, dapi-client, and platform-wallet so their
source paths no longer conflict. Ensure the final .codecov.yml maps each
component to non-ignored paths and re-run CI to confirm coverage buckets are
populated.
Summary
Expands
.codecov.ymlexclusions to remove non-unit-testable code from the coverage denominator. This is a config-only change — no code modifications.New whole-crate exclusions
Broadened patterns
**/accessors/**and**/accessors.rsacross all crates (was individual files)Consolidated
Removed redundant individual file exclusions now covered by broader patterns (e.g., individual rs-dapi files replaced by
packages/rs-dapi/src/**).Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes