Skip to content

test(drive): improve coverage for storage forms, batch operations, and vote resolution#3449

Merged
QuantumExplorer merged 1 commit into
v3.1-devfrom
test/drive-storage-ops-coverage
Apr 7, 2026
Merged

test(drive): improve coverage for storage forms, batch operations, and vote resolution#3449
QuantumExplorer merged 1 commit into
v3.1-devfrom
test/drive-storage-ops-coverage

Conversation

@QuantumExplorer
Copy link
Copy Markdown
Member

@QuantumExplorer QuantumExplorer commented Apr 7, 2026

Summary

Adds 107 tests across 5 modules in rs-drive covering storage operations and batch handling.

Module Tests What's covered
contested_document_resource_storage_form 12 try_from_tree_path for all vote choices, path validation errors
contract_info 20 All DataContractResolvedInfo variants, DocumentTypeInfo resolve errors
contested_document_resource_vote_poll 17 Serialization, hashing, resolution with contract matching/mismatch
drive_op_batch/document 4 Operation construction for add/delete/update
grovedb_op_batch 54 Core ops, Display formatting, known_path() for all 30+ path patterns

Test plan

  • cargo test -p drive passes
  • cargo fmt --all clean
  • CI

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests

  • Added comprehensive integration test suite for drive storage operations and utilities. Tests cover vote storage form parsing and validation, contract information handling and conversions, document operation batching, and database utilities with extensive validation of conversions, serialization, error handling, and edge cases across various boundary conditions and encoding scenarios.

…d vote resolution

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added this to the v3.1.0 milestone Apr 7, 2026
@thepastaclaw
Copy link
Copy Markdown
Collaborator

thepastaclaw commented Apr 7, 2026

Review Gate

Commit: 15f459f8

  • Debounce: 14m ago (need 30m)

  • CI checks: builds passed, 0/2 tests passed

  • CodeRabbit review: no comment yet

  • Off-peak hours: off-peak (04:24 PM PT Tuesday)

  • Run review now (check to override)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.96%. Comparing base (0c72404) to head (15f459f).
⚠️ Report is 6 commits behind head on v3.1-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           v3.1-dev    #3449      +/-   ##
============================================
+ Coverage     81.35%   82.96%   +1.61%     
============================================
  Files          2852     2621     -231     
  Lines        291561   269179   -22382     
============================================
- Hits         237188   223315   -13873     
+ Misses        54373    45864    -8509     
Components Coverage Δ
dpp 75.21% <ø> (+0.83%) ⬆️
drive 84.05% <ø> (+0.54%) ⬆️
drive-abci 86.74% <ø> (+0.04%) ⬆️
sdk ∅ <ø> (∅)
dapi-client ∅ <ø> (∅)
platform-version ∅ <ø> (∅)
platform-value 92.00% <ø> (ø)
platform-wallet ∅ <ø> (∅)
drive-proof-verifier 55.66% <ø> (+0.40%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@QuantumExplorer QuantumExplorer merged commit dbd8bf0 into v3.1-dev Apr 7, 2026
38 checks passed
@QuantumExplorer QuantumExplorer deleted the test/drive-storage-ops-coverage branch April 7, 2026 23:27
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a901cecf-1ba0-4783-8d8f-9cb9b14d1dba

📥 Commits

Reviewing files that changed from the base of the PR and between 1d01943 and 15f459f.

📒 Files selected for processing (1)
  • packages/rs-drive/tests/drive_storage_ops_coverage.rs

📝 Walkthrough

Walkthrough

A new comprehensive test file is introduced that provides extensive test coverage for drive storage operations, including vote storage forms, contract information utilities, document operation batches, and GroveDB operation handling. The tests validate parsing, conversions, serialization, and error conditions across multiple related components.

Changes

Cohort / File(s) Summary
New Test Coverage Module
packages/rs-drive/tests/drive_storage_ops_coverage.rs
Comprehensive test suite with 1685 lines covering vote storage form parsing and validation, contract-info conversions and borrowing semantics, vote-poll resolution with serialization and hashing verification, document operation batch construction, and GroveDB operation batch behavior including emptiness checks, push/extend/append operations, removal semantics, iteration, and formatted output expectations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A warren of tests now stands so tall,
Checking vote paths, contracts, and more,
With GroveDB ops we cover it all,
Each assertion a tunnel to explore,
Our burrow of coverage runs deep to the core!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/drive-storage-ops-coverage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants