test(drive-abci): improve coverage for quorum sets, block proposals, and identity nonces#3453
Conversation
…sal, and identity nonces Add 71 unit tests covering: - SignatureVerificationQuorumSetV0: construction, quorum replacement, rotation tracking, and the select_quorums logic across all height-based branches - Quorums<Q>: default/collection construction, classic DIP8 and rotating DIP24 quorum selection, determinism, and edge cases - BlockProposal: TryFrom conversions for both RequestPrepareProposal and RequestProcessProposal, field validation, error paths, and Debug formatting - StateTransitionHasIdentityNonceValidationV0: version 0 vs version 1 dispatch for multiple state transition variants and unknown-version error handling Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 29 minutes and 32 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review GateCommit:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3.1-dev #3453 +/- ##
============================================
+ Coverage 83.13% 83.23% +0.09%
============================================
Files 2621 2621
Lines 270434 271308 +874
============================================
+ Hits 224833 225815 +982
+ Misses 45601 45493 -108
🚀 New features to boost your workflow:
|
Summary
Adds 71 tests across 4 files in rs-drive-abci.
quorum_set.rsquorums.rsblock_proposal/v0.rsidentity_nonces.rsTest plan
cargo test -p drive-abci --libpassescargo fmt --allclean🤖 Generated with Claude Code