Skip to content

test(drive-abci): improve coverage for quorum sets, block proposals, and identity nonces#3453

Merged
QuantumExplorer merged 1 commit into
v3.1-devfrom
test/drive-abci-quorum-proposal
Apr 8, 2026
Merged

test(drive-abci): improve coverage for quorum sets, block proposals, and identity nonces#3453
QuantumExplorer merged 1 commit into
v3.1-devfrom
test/drive-abci-quorum-proposal

Conversation

@QuantumExplorer
Copy link
Copy Markdown
Member

Summary

Adds 71 tests across 4 files in rs-drive-abci.

File Tests What's covered
quorum_set.rs 21 Construction, quorum replacement/rotation, select_quorums all branches, iterator
quorums.rs 18 Classic/rotating quorum selection, FromIterator, choose_quorum
block_proposal/v0.rs 19 TryFrom for prepare/process proposals, error paths, field validation
identity_nonces.rs 13 v0/v1 dispatch for all state transition types, unknown version error

Test plan

  • cargo test -p drive-abci --lib passes
  • cargo fmt --all clean
  • CI

🤖 Generated with Claude Code

…sal, and identity nonces

Add 71 unit tests covering:
- SignatureVerificationQuorumSetV0: construction, quorum replacement, rotation
  tracking, and the select_quorums logic across all height-based branches
- Quorums<Q>: default/collection construction, classic DIP8 and rotating DIP24
  quorum selection, determinism, and edge cases
- BlockProposal: TryFrom conversions for both RequestPrepareProposal and
  RequestProcessProposal, field validation, error paths, and Debug formatting
- StateTransitionHasIdentityNonceValidationV0: version 0 vs version 1 dispatch
  for multiple state transition variants and unknown-version error handling

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2026

Warning

Rate limit exceeded

@QuantumExplorer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 32 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 29 minutes and 32 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5d222748-7d22-4fb6-a33c-c9480fd063a3

📥 Commits

Reviewing files that changed from the base of the PR and between 59f233f and 7a9446e.

📒 Files selected for processing (4)
  • packages/rs-drive-abci/src/execution/validation/state_transition/processor/traits/identity_nonces.rs
  • packages/rs-drive-abci/src/platform_types/block_proposal/v0.rs
  • packages/rs-drive-abci/src/platform_types/signature_verification_quorum_set/v0/quorum_set.rs
  • packages/rs-drive-abci/src/platform_types/signature_verification_quorum_set/v0/quorums.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/drive-abci-quorum-proposal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added this to the v3.1.0 milestone Apr 8, 2026
@thepastaclaw
Copy link
Copy Markdown
Collaborator

thepastaclaw commented Apr 8, 2026

Review Gate

Commit: 7a9446eb

  • Debounce: 4m ago (need 30m)

  • CI checks: checks still running (2 pending)

  • CodeRabbit review: comment found

  • Off-peak hours: off-peak (11:57 PM PT Tuesday)

  • Run review now (check to override)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 98.28375% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.23%. Comparing base (59f233f) to head (7a9446e).
⚠️ Report is 1 commits behind head on v3.1-dev.

Files with missing lines Patch % Lines
...ate_transition/processor/traits/identity_nonces.rs 94.25% 12 Missing ⚠️
...es/signature_verification_quorum_set/v0/quorums.rs 98.63% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           v3.1-dev    #3453      +/-   ##
============================================
+ Coverage     83.13%   83.23%   +0.09%     
============================================
  Files          2621     2621              
  Lines        270434   271308     +874     
============================================
+ Hits         224833   225815     +982     
+ Misses        45601    45493     -108     
Components Coverage Δ
dpp 76.11% <ø> (ø)
drive 84.05% <ø> (ø)
drive-abci 87.03% <98.28%> (+0.28%) ⬆️
sdk ∅ <ø> (∅)
dapi-client ∅ <ø> (∅)
platform-version ∅ <ø> (∅)
platform-value 92.00% <ø> (ø)
platform-wallet ∅ <ø> (∅)
drive-proof-verifier 55.66% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@QuantumExplorer QuantumExplorer merged commit d430e25 into v3.1-dev Apr 8, 2026
39 checks passed
@QuantumExplorer QuantumExplorer deleted the test/drive-abci-quorum-proposal branch April 8, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants