fix(sdk): add Regtest support to trusted context provider activation height#3464
Conversation
…height get_platform_activation_height() only handled Mainnet, Testnet, and Devnet, returning "Unsupported network" for Regtest. This caused the nightly functional tests to fail with "Context provider error: Unsupported network" since they run on a local regtest network. Add Regtest to the Devnet match arm with activation height 1. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review GateCommit:
|
Issue Being Fixed
Nightly "Packages functional tests" fail with:
Root Cause
get_platform_activation_height()inrs-sdk-trusted-context-provider/src/provider.rsonly handlesMainnet,Testnet, andDevnet. The functional tests run on a local regtest network, which hits the_wildcard and returns an error.What was changed
Added
Network::Regtestto theDevnetmatch arm with activation height1(same as Devnet — platform activates at genesis on local/test networks).Breaking Changes
None. Previously Regtest always errored; now it works.
🤖 Generated with Claude Code
Summary by CodeRabbit