ci: exclude Drive state transition action boilerplate from coverage#3474
ci: exclude Drive state transition action boilerplate from coverage#3474QuantumExplorer wants to merge 1 commit into
Conversation
The state_transition_action tree in rs-drive contains version dispatch enums (single-variant match arms), getter/setter trait impls, struct definitions, and top-level transformer delegation. These are mechanical patterns tested through drive-abci integration tests, not unit-testable logic. Excludes mod.rs, v0/mod.rs, transformer.rs, and *_action_type.rs for token, document, identity, contract, and system transition actions. Does NOT exclude v0/transformer.rs which contains real conversion logic. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review GateCommit:
|
|
Closing — excluding boilerplate from coverage just hides the metric without adding value. The real fix is either testing through integration paths or generating these with derive macros. |
What was changed
Added codecov exclusions for Drive state transition action boilerplate files in
packages/rs-drive/src/state_transition_action/.These files contain:
mod.rs— Version dispatch enums with single-variant match arms delegating to V0 (match self { V0(v0) => v0.field })v0/mod.rs— Struct definitions + getter/setter trait impls (pure field accessors)transformer.rs(top-level) — Single-variant match delegating toV0::try_from(...)*_action_type.rs— Type enum definitionsNOT excluded:
v0/transformer.rsfiles which contain real conversion logic (300-580 lines each).Affected paths
token_burn,token_mint,token_transfer,token_freeze,token_unfreeze,token_claim,token_config_update,token_destroy_frozen_funds,token_emergency_action,token_direct_purchase,token_set_price_for_direct_purchase,token_basedocument_create,document_delete,document_replace,document_transfer,document_purchase,document_update_price,document_baseidentity_create,identity_topup,identity_update,identity_credit_withdrawal,identity_credit_transfer, etc.data_contract_create,data_contract_updatebump_identity_nonce_action,bump_address_input_nonces_action,partially_use_asset_lock_action, etc.These are tested through drive-abci integration/strategy tests, not individually unit-testable.
🤖 Generated with Claude Code
Summary by CodeRabbit