ci: skip ssh2 optional crypto native build#3520
Conversation
ssh2 (pulled in transitively via docker-modem) ships an optional native "sshcrypto" binding built via node-gyp + nan. On Node 24 the vendored nan versions (2.17/2.22) don't compile against V8's newer Intercepted/ScriptOriginOptions API, producing a wall of C++ errors during `yarn install --inline-builds`. The failure is cosmetic — ssh2 catches it and falls back to pure-JS crypto, reporting "Failed to build optional crypto binding" — but the noise makes real install issues much harder to spot in CI logs. Disable the build script via dependenciesMeta so yarn doesn't try to compile the optional binding at all. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 46 minutes and 26 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review GateCommit:
|
Issue being fixed or feature implemented
ssh2— pulled in transitively viadocker-modem— ships an optional "sshcrypto" native binding built vianode-gyp+nan. On Node 24 the vendorednanversions (2.17 / 2.22) don't compile against V8's newerIntercepted/ScriptOriginOptionsAPI, producing a wall of C++ errors duringyarn install --inline-builds.Example log (from a CI run on #3516):
The failure is cosmetic — ssh2 catches it and falls back to pure-JS crypto. But the noise makes real install failures (e.g. the EBADF race addressed separately in #3519) much harder to spot.
What was done?
Added
dependenciesMetain the rootpackage.jsonto setbuilt: falseon both resolvedssh2versions (1.11.0 and 1.16.0). yarn skips the postinstall build script entirely, so the native compile never runs.How Has This Been Tested?
yarn install --mode=skip-buildlocally — config accepted, no warnings beyond pre-existing peer-dep messages.yarn.lockreflects the metadata in the workspace root entry.Functional verification: ssh2 itself already runs in a "build failed, fall back" mode in production CI today, so disabling the build is strictly a superset of the current behavior.
Breaking Changes
None. ssh2 already operates without the optional native binding in all CI runs; this just avoids attempting the build.
Checklist: