test(platform-wallet): CR-004 spec — legacy BIP32 account UTXO update (dash-evo-tool#845)#3610
Conversation
…UTXO update after spend (dash-evo-tool#845) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR #3609 lands V18→V20 fixes and the parallelism contract. Update TEST_SPEC entries to reflect: - TK-013, PA-001b, PA-005b → PASS after fixes - TK-002, CR-003 → PASS (stabilised) - CR-004 → ENV-GATED FAILING-by-design escape (PLATFORM_WALLET_E2E_RUN_FAILING_BY_DESIGN=1) - bank.fund_address: chain-confirmed-nonce wait (upstream #3611) - Parallelism: PA-002, PA-008c, id_sweep parallel-safe - SPV: enabled by default; PLATFORM_WALLET_E2E_DISABLE_SPV is escape hatch only (rust-dashcore #470 contingency) - Wave E: marked COMPLETE; Task #15 done; CR-001/CR-002 PASS-pending-validation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Review GateCommit:
|
Resolves conflicts in TEST_SPEC.md by semantically merging the post-PR-#3609 sync entries (cr004-spec) with the test-branch's own spec edits (ID-007 restoration, CR-003 flip, etc.) that were absorbed via the test-into-feat collapse. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> # Conflicts: # packages/rs-platform-wallet/tests/e2e/TEST_SPEC.md
Bring in v3.1-dev's commits via the cascade. Spec is markdown-only — no build implications. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
Adds CR-004 SPEC entry for the upstream bug dashpay/dash-evo-tool#845: SPV: Legacy BIP32 Account UTXOs not updated after transfer.
After sending all funds from a legacy BIP32 account using the advanced (explicit input selection) path, the wallet's local balance/UTXO state is not refreshed. A follow-up
send_to_addressesthen fails withCoin selection error: No UTXOs available for selectioninstead of a clean insufficient-funds error.What this PR adds
#### CR-004entry intests/e2e/TEST_SPEC.mdunder theCore / SPV (CR)sectionWhat this PR does NOT add
cases/cr_004_legacy_bip32_utxo_update_after_spend.rs)src/wallet/core/Both implementation pieces will land in PR #3609 so the spec lands cleanly on
feat/rs-platform-wallet-e2eindependently of the QA fix wave.Harness extensions called out in spec
setup_with_legacy_bip32_funded_account(funding_duffs, utxo_count)— analogous to existingsetup_with_core_funded_test_walletbut on the legacy DIP-9 pathwait_for_core_balance(target=0)from CR-003Test plan
grep -A 30 "^#### CR-004"renders the new entry cleanly🤖 Co-authored by Claudius the Magnificent AI Agent