Skip to content

test(platform-wallet): CR-004 spec — legacy BIP32 account UTXO update (dash-evo-tool#845)#3610

Merged
lklimek merged 4 commits into
feat/rs-platform-wallet-e2efrom
feat/rs-platform-wallet-e2e-cr004-spec
May 7, 2026
Merged

test(platform-wallet): CR-004 spec — legacy BIP32 account UTXO update (dash-evo-tool#845)#3610
lklimek merged 4 commits into
feat/rs-platform-wallet-e2efrom
feat/rs-platform-wallet-e2e-cr004-spec

Conversation

@Claudius-Maginificent
Copy link
Copy Markdown
Collaborator

Summary

Adds CR-004 SPEC entry for the upstream bug dashpay/dash-evo-tool#845: SPV: Legacy BIP32 Account UTXOs not updated after transfer.

After sending all funds from a legacy BIP32 account using the advanced (explicit input selection) path, the wallet's local balance/UTXO state is not refreshed. A follow-up send_to_addresses then fails with Coin selection error: No UTXOs available for selection instead of a clean insufficient-funds error.

What this PR adds

  • #### CR-004 entry in tests/e2e/TEST_SPEC.md under the Core / SPV (CR) section
  • Quick-index row for CR-004 with priority/status

What this PR does NOT add

  • The test body (cases/cr_004_legacy_bip32_utxo_update_after_spend.rs)
  • The production fix in src/wallet/core/

Both implementation pieces will land in PR #3609 so the spec lands cleanly on feat/rs-platform-wallet-e2e independently of the QA fix wave.

Harness extensions called out in spec

  • setup_with_legacy_bip32_funded_account(funding_duffs, utxo_count) — analogous to existing setup_with_core_funded_test_wallet but on the legacy DIP-9 path
  • Reuse of wait_for_core_balance(target=0) from CR-003

Test plan

  • grep -A 30 "^#### CR-004" renders the new entry cleanly
  • No build needed — markdown only

🤖 Co-authored by Claudius the Magnificent AI Agent

…UTXO update after spend (dash-evo-tool#845)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 89df65d2-bf31-4134-ade9-20090aa3b26a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/rs-platform-wallet-e2e-cr004-spec

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

PR #3609 lands V18→V20 fixes and the parallelism contract. Update
TEST_SPEC entries to reflect:
- TK-013, PA-001b, PA-005b → PASS after fixes
- TK-002, CR-003 → PASS (stabilised)
- CR-004 → ENV-GATED FAILING-by-design escape (PLATFORM_WALLET_E2E_RUN_FAILING_BY_DESIGN=1)
- bank.fund_address: chain-confirmed-nonce wait (upstream #3611)
- Parallelism: PA-002, PA-008c, id_sweep parallel-safe
- SPV: enabled by default; PLATFORM_WALLET_E2E_DISABLE_SPV is escape
  hatch only (rust-dashcore #470 contingency)
- Wave E: marked COMPLETE; Task #15 done; CR-001/CR-002 PASS-pending-validation

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@lklimek lklimek marked this pull request as ready for review May 7, 2026 10:25
@lklimek lklimek requested a review from QuantumExplorer as a code owner May 7, 2026 10:25
@lklimek lklimek changed the title docs(rs-platform-wallet/e2e): CR-004 spec — legacy BIP32 account UTXO update (dash-evo-tool#845) test(platform-wallet): CR-004 spec — legacy BIP32 account UTXO update (dash-evo-tool#845) May 7, 2026
@thepastaclaw
Copy link
Copy Markdown
Collaborator

thepastaclaw commented May 7, 2026

Review Gate

Commit: 5451e410

  • Debounce: 10m ago (need 30m)

  • CI checks: build failure: PR title

  • CodeRabbit review: comment found

  • Off-peak hours: off-peak (04:51 AM PT Thursday)

  • Run review now (check to override)

lklimek and others added 2 commits May 7, 2026 12:45
Resolves conflicts in TEST_SPEC.md by semantically merging the
post-PR-#3609 sync entries (cr004-spec) with the test-branch's
own spec edits (ID-007 restoration, CR-003 flip, etc.) that
were absorbed via the test-into-feat collapse.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

# Conflicts:
#	packages/rs-platform-wallet/tests/e2e/TEST_SPEC.md
Bring in v3.1-dev's commits via the cascade. Spec is markdown-only —
no build implications.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@lklimek lklimek merged commit 589b5b2 into feat/rs-platform-wallet-e2e May 7, 2026
1 of 3 checks passed
@lklimek lklimek deleted the feat/rs-platform-wallet-e2e-cr004-spec branch May 7, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants