chore(dapi-grpc): regenerate obj-c client for count-query doc updates#3631
Conversation
The proto comments on `GetDocumentsCountRequestV0.order_by` and `.limit` were rewritten in #3623 (commit 0f52734) to reflect the final count-query semantics: - `order_by` is no longer "Required when `where` carries an `In` or range operator on the prove path" — that claim was tied to the deleted materialize-and-count walker. The `PointLookupProof` path sorts In keys lex-ascending unconditionally, and only `RangeDistinctProof` makes `order_by` load-bearing (with empty defaulting to ascending on both prover and verifier sides). - `limit` is "validate-don't-clamp" on the prove path (`InvalidLimit` rejection when `limit > max_query_limit`) rather than silently clamping, because silent clamping would break proof verification. Unset falls back to the compile-time `DEFAULT_QUERY_LIMIT` constant, so proof bytes stay deterministic across operators regardless of their runtime `default_query_limit` tuning. #3623 updated the proto file but didn't re-run the obj-c codegen, leaving `Platform.pbobjc.h` with the pre-rewrite comments. This catches the generated client up. No semantic change — only the docstrings in the header file. The other generated clients (java, nodejs, python, rust, web) were already in sync at merge time; obj-c is the only outlier.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocumentation for ChangesGetDocumentsCountRequest field documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review GateCommit:
|
Issue being fixed or feature implemented
#3623 rewrote the proto comments on `GetDocumentsCountRequestV0.order_by` and `.limit` (in commit `0f52734820`) to reflect the final count-query semantics, but didn't re-run the obj-c codegen. The generated `Platform.pbobjc.h` still carries the pre-rewrite docstrings referencing the deleted materialize-and-count walker. This PR catches the obj-c client up.
The other generated clients (java, nodejs, python, rust, web) were already in sync at merge time — obj-c is the only outlier.
What was done?
Regenerated `packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbobjc.h` so its inline doc-comments match the proto source. Two fields updated:
How Has This Been Tested?
Header-only change in a generated file. No semantic difference — the docstrings are the only thing that changed. Existing CI on dapi-grpc covers the generated client structurally; no new tests warranted.
Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code
Summary by CodeRabbit