feat(drive): provide latest core chain lock on init chain#659
Merged
Conversation
shumkov
changed the title
shumkov
requested changes
Dec 7, 2022
shumkov
approved these changes
Dec 8, 2022
QuantumExplorer
added a commit
that referenced
this pull request
May 10, 2026
The v12 protocol transition was still parenting the main shielded credit pool under AddressBalances and creating only 4 of the 8 inner subtrees, which would diverge from a fresh genesis-12 chain (created by v3 init) on any node that actually migrated from v11. Rewrite it to mirror v3 init: - Insert RootTree::ShieldedBalances as a top-level SumTree. - Parent the main pool under [ShieldedBalances] / "M". - Insert all 8 inner subtrees in BFS order: notes, nullifiers, anchors_in_pool, total_balance, anchors_by_height, recent_nullifiers (wrapped in NotSummed), compacted_nullifiers, expiration_time. - Update the two post-condition assertions in the in-file tests. Also fix CI: the grovedb bump (PR #659/#656) added a new QueryItem::AggregateCountOnRange variant. wasm-drive-verify wasn't in my local check set and had a non-exhaustive match in token_transition.rs that broke the macOS workspace build. Reject the variant with a clear error message. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Need to return
nextCoreChainLockUpdateon init chain.What was done?
nextCoreChainLockUpdateparam added to init chain response.How Has This Been Tested?
With tests
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only