feat(drive): log number of refunded epochs#729
Merged
Conversation
shumkov
requested changes
Jan 17, 2023
added 2 commits
January 17, 2023 17:03
shumkov
requested changes
Jan 17, 2023
shumkov
added a commit
that referenced
this pull request
May 5, 2026
…e PR dashcore PR #729 (dashpay/rust-dashcore#729) is the companion to #708 — same `ContentDeserializer` HR-quirk root cause, but for the separate `hashes::serde_macros::SerdeHash` macro family that generates `Txid` / `BlockHash` / `ProTxHash` / `PubkeyHash` / `QuorumHash` etc. (vs. #708 which fixed `OutPoint` via `serde_struct_human_string_impl!`). Update the two `#[ignore]` notes on `Validator::value_round_trip` and `ValidatorSet::value_round_trip` to reference #729 instead of the vague "follow-up PR" phrasing. When #729 lands and we bump dashcore, drop the `#[ignore]`s. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
shumkov
added a commit
that referenced
this pull request
May 11, 2026
dashcore PRs #708 (OutPoint dual-shape visitor) and #729 (hashes::serde_macros::SerdeHash dual-shape visitor) merged upstream on 2026-05-06. The v3.1-dev base branch already bumped the dashcore rev (d6dd5da1) to include both fixes; merging v3.1-dev into this branch pulled the new rev. The local workarounds we'd added on this branch are no longer needed: - Deleted the local `outpoint_serde` mod in `chain/chain_asset_lock_proof.rs` (was ~150 lines). dashcore's upstream Deserialize now correctly handles `ContentDeserializer` HR-quirk for OutPoint through tagged enums. - Unignored `Validator::value_round_trip_with_full_wire_shape` — the ProTxHash/PubkeyHash hex/bytes dual-shape is now upstream via #729. - Re-ignored `ValidatorSet::value_round_trip_with_full_wire_shape` with an updated comment: the test still fails because its fixture has a non-None BLS `threshold_public_key`, which routes through the local `bls_pubkey_serde` wrapper. That wrapper depends on a separate blstrs_plus upstream PR (not dashcore #708/#729). Once blstrs_plus lands, drop the wrapper and unignore this test too. Drive-by: the merge from v3.1-dev introduced `test_countable_allowing_offset_variant_end_to_end` in `drive/src/query/drive_document_count_query/tests.rs` which used the now-deleted `DataContract::from_json(_, false, _)` legacy method. Migrated to canonical `serde_json::from_value::<DataContract>(...)` (no-validation default matches the false flag the test passed). Verification: cargo test -p dpp --features all_features_without_client --lib -> 3619 passed, 0 failed, 7 ignored (was 3618 post-merge with 8 ignored; 1 unignore + zero new failures) cargo check -p drive -p drive-abci -p wasm-dpp -p wasm-dpp2 -p dash-sdk -p rs-sdk-ffi --tests clean (only pre-existing warnings) Plan doc updated: final test count refreshed to 3619/7. Upstream PRs status section reflects: dashcore #708/#729 merged + integrated; blstrs_plus still pending.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Log number of refunded epochs in drive
What was done?
Additional
refundedEpochsCountfield was added to logsHow Has This Been Tested?
With tests
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only