Skip to content

fix(dashmate): Dash Core container is unable to restart properly under WSL#736

Merged
jawid-h merged 9 commits into
v0.24-devfrom
fix/wsl2-restart-issue
Jan 18, 2023
Merged

fix(dashmate): Dash Core container is unable to restart properly under WSL#736
jawid-h merged 9 commits into
v0.24-devfrom
fix/wsl2-restart-issue

Conversation

@jawid-h
Copy link
Copy Markdown
Contributor

@jawid-h jawid-h commented Jan 17, 2023

Issue being fixed or feature implemented

Trying to solve WSL2 restart issue using dynamic ENV variable for Core container

What was done?

  • updated docker-compose file and generating ENV variable using Date()

How Has This Been Tested?

local env

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h changed the title chore: initial commit fix: Dash Core container is unable to restart properly under WSL Jan 17, 2023
Comment thread packages/dashmate/src/docker/DockerCompose.js Outdated
Comment thread packages/dashmate/docker-compose.yml Outdated
@shumkov shumkov changed the title fix: Dash Core container is unable to restart properly under WSL fix(dashmate): Dash Core container is unable to restart properly under WSL Jan 17, 2023
@jawid-h jawid-h requested a review from shumkov January 17, 2023 11:40
Comment thread packages/dashmate/src/docker/DockerCompose.js Outdated
@jaboski
Copy link
Copy Markdown
Contributor

jaboski commented Jan 17, 2023

Dashmate-helper crashing for me with:
Cannot read properties of undefined (reading 'log')
Sent you full log of the error.
Steps:

  • yarn dashmate setup local
  • yarn dashmate group start

@jawid-h jawid-h requested a review from shumkov January 17, 2023 18:29
@pshenmic
Copy link
Copy Markdown
Collaborator

@jaboski sorry it was messed up by my last commits. this pr should resolve it
#738

@jawid-h could you kindly pull this in?

@jawid-h
Copy link
Copy Markdown
Contributor Author

jawid-h commented Jan 18, 2023

@jaboski @pshenmic Merged #738

Comment thread packages/dashmate/src/docker/DockerCompose.js Outdated
@jawid-h jawid-h requested a review from pshenmic January 18, 2023 11:11
shumkov
shumkov previously approved these changes Jan 18, 2023
Copy link
Copy Markdown
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaboski
Copy link
Copy Markdown
Contributor

jaboski commented Jan 18, 2023

No more issue with crashing dashmate-helper. I also checked setup, start, stop, restart and reset for local under wsl - works fine for me 👍

@jawid-h jawid-h merged commit e39dfe4 into v0.24-dev Jan 18, 2023
@jawid-h jawid-h deleted the fix/wsl2-restart-issue branch January 18, 2023 13:08
@thephez thephez added this to the v0.24.0 milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants