Skip to content

fix(dashmate): api binds to all interfaces#893

Merged
shumkov merged 28 commits into
v0.24-devfrom
feat/dashmate-json-rpc
Apr 7, 2023
Merged

fix(dashmate): api binds to all interfaces#893
shumkov merged 28 commits into
v0.24-devfrom
feat/dashmate-json-rpc

Conversation

@pshenmic
Copy link
Copy Markdown
Collaborator

@pshenmic pshenmic commented Apr 7, 2023

Issue being fixed or feature implemented

Bind dashmate to localhost for security reason.

What was done?

  • bind dashmate rpc api to 127.0.0.1
  • add curl to dashmate docker image (used in smoke tests)

How Has This Been Tested?

Locally

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title feat(dashmate): bind dashmate json rpc to localhost fix(dashmate): dashmate api binds to all interfaces Apr 7, 2023
@shumkov shumkov changed the title fix(dashmate): dashmate api binds to all interfaces fix(dashmate): api binds to all interfaces Apr 7, 2023
Copy link
Copy Markdown
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit c3e5a71 into v0.24-dev Apr 7, 2023
@shumkov shumkov deleted the feat/dashmate-json-rpc branch April 7, 2023 17:07
@thephez thephez added this to the v0.24.0 milestone Apr 24, 2023
markin-io pushed a commit that referenced this pull request Apr 26, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@markin-io markin-io mentioned this pull request Apr 26, 2023
5 tasks
markin-io pushed a commit that referenced this pull request Apr 26, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants